Add GDALViewshedGenerate binding #142
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… > 3.10 (not sure about this approach...)
… compatible GDAL versions
… WILL run, but produces invalid test results
Question: Invalid test results across GDAL versionsI found in my testing that different versions of GDAL pass different sections of the test:
My solution for this is to return an error for any case where tests produce an invalid result, the current behaviour for the above is:
Do you prefer the approach I've implemented, which prevents the user from running |
… case in `TestViewshedCreationOptions`
|
@tbonfort I'm not sure if you're being notified about new PRs, but I'd really appreciate it if you could review this PR when you get the chance |
tbonfort
requested changes
Feb 11, 2025
| #if GDAL_VERSION_NUM >= GDAL_COMPUTE_VERSION(3, 1, 0) | ||
| ret = GDALViewshedGenerate(bnd, pszDriverName, pszTargetRasterName, papszCreationOptions, dfObserverX, dfObserverY, dfObserverHeight, dfTargetHeight, dfVisibleVal, dfInvisibleVal, dfOutOfRangeVal, | ||
| dfNoDataVal, dfCurvCoeff, GDALViewshedMode(eMode), dfMaxDistance, nullptr, nullptr, GDALViewshedOutputType(heightMode), nullptr); | ||
| #endif |
There was a problem hiding this comment.
Suggested change
| #endif | |
| #else | |
| CPLError(CE_Failure, CPLE_AppDefined, "Viewshed not implemented in gdal < 3.1"); | |
| #endif |
Comment on lines
+4107
to
+4114
| // TODO: Should I put a 'warning' in the documentation for `Viewshed` instead of disallowing the last two configurations? | ||
| if !CheckMinVersion(3, 1, 0) { | ||
| return nil, errors.New("failed to run, 'viewshed' not supported on GDAL versions < 3.1.0") | ||
| } else if !CheckMinVersion(3, 4, 2) { | ||
| return nil, errors.New("cannot run 'viewshed' with GDAL version <= 3.4.1, as some tests produce invalid results under these conditions") | ||
| } else if !CheckMinVersion(3, 10, 0) && heightMode == MinTargetHeightFromDem { | ||
| return nil, errors.New("height mode CANNOT be `MinTargetHeightFromDem` when running a GDAL version < 3.10, as some tests produce invalid results under these conditions") | ||
| } |
There was a problem hiding this comment.
I would just leave this section out, it is not godal's role to circumvent fixed bugs in gdal. A comment with a link to the gdal PR/issue numbers is sufficient I believe
Comment on lines
+4445
to
+4453
| if !CheckMinVersion(3, 1, 0) { | ||
| _, err := Viewshed(Band{}, nil, "none", 1, 1, 0, 0, 255, 0, 0, -1, 0, MEdge, 0, Normal) | ||
| assert.EqualError(t, err, "failed to run, 'viewshed' not supported on GDAL versions < 3.1.0") | ||
| return | ||
| } else if !CheckMinVersion(3, 4, 2) { | ||
| _, err := Viewshed(Band{}, nil, "none", 1, 1, 0, 0, 255, 0, 0, -1, 0, MEdge, 0, Normal) | ||
| assert.EqualError(t, err, "cannot run 'viewshed' with GDAL version <= 3.4.1, as some tests produce invalid results under these conditions") | ||
| return | ||
| } |
There was a problem hiding this comment.
these versions of gdal are too old, no need to test for this.
Suggested change
| if !CheckMinVersion(3, 1, 0) { | |
| _, err := Viewshed(Band{}, nil, "none", 1, 1, 0, 0, 255, 0, 0, -1, 0, MEdge, 0, Normal) | |
| assert.EqualError(t, err, "failed to run, 'viewshed' not supported on GDAL versions < 3.1.0") | |
| return | |
| } else if !CheckMinVersion(3, 4, 2) { | |
| _, err := Viewshed(Band{}, nil, "none", 1, 1, 0, 0, 255, 0, 0, -1, 0, MEdge, 0, Normal) | |
| assert.EqualError(t, err, "cannot run 'viewshed' with GDAL version <= 3.4.1, as some tests produce invalid results under these conditions") | |
| return | |
| } |
Comment on lines
+4575
to
+4583
| if !CheckMinVersion(3, 1, 0) { | ||
| _, err := Viewshed(Band{}, nil, "none", 1, 1, 0, 0, 255, 0, 0, -1, 0, MEdge, 0, Normal) | ||
| assert.EqualError(t, err, "failed to run, 'viewshed' not supported on GDAL versions < 3.1.0") | ||
| return | ||
| } else if !CheckMinVersion(3, 4, 2) { | ||
| _, err := Viewshed(Band{}, nil, "none", 1, 1, 0, 0, 255, 0, 0, -1, 0, MEdge, 0, Normal) | ||
| assert.EqualError(t, err, "cannot run 'viewshed' with GDAL version <= 3.4.1, as some tests produce invalid results under these conditions") | ||
| return | ||
| } |
There was a problem hiding this comment.
these versions of gdal are too old, no need to test for this.
Suggested change
| if !CheckMinVersion(3, 1, 0) { | |
| _, err := Viewshed(Band{}, nil, "none", 1, 1, 0, 0, 255, 0, 0, -1, 0, MEdge, 0, Normal) | |
| assert.EqualError(t, err, "failed to run, 'viewshed' not supported on GDAL versions < 3.1.0") | |
| return | |
| } else if !CheckMinVersion(3, 4, 2) { | |
| _, err := Viewshed(Band{}, nil, "none", 1, 1, 0, 0, 255, 0, 0, -1, 0, MEdge, 0, Normal) | |
| assert.EqualError(t, err, "cannot run 'viewshed' with GDAL version <= 3.4.1, as some tests produce invalid results under these conditions") | |
| return | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GDALViewshedGeneratebindingViewshedgo function (calls binding)TestViewshedSimpleHeightto test the binding