Skip to content

Commit

Permalink
rename flag helm-chart-version -> chart-version
Browse files Browse the repository at this point in the history
  • Loading branch information
colesnodgrass committed May 13, 2024
1 parent a1712c7 commit d91191a
Showing 1 changed file with 11 additions and 7 deletions.
18 changes: 11 additions & 7 deletions internal/cmd/local/local_install.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ func NewCmdInstall(provider k8s.Provider) *cobra.Command {
spinner := &pterm.DefaultSpinner

var (
flagHelmChartVersion string
flagUsername string
flagPassword string
flagPort int
flagChartVersion string
flagUsername string
flagPassword string
flagPort int
)

cmd := &cobra.Command{
Expand Down Expand Up @@ -102,8 +102,12 @@ func NewCmdInstall(provider k8s.Provider) *cobra.Command {
pterm.Success.Printfln("Cluster '%s' created", provider.ClusterName)
}

lc, err := local.New(provider, local.WithPortHTTP(flagPort),
local.WithTelemetryClient(telClient), local.WithSpinner(spinner), local.WithHelmChartVersion(flagHelmChartVersion))
lc, err := local.New(provider,
local.WithPortHTTP(flagPort),
local.WithTelemetryClient(telClient),
local.WithSpinner(spinner),
local.WithHelmChartVersion(flagChartVersion),
)
if err != nil {
pterm.Error.Printfln("Failed to initialize 'local' command")
return fmt.Errorf("could not initialize local command: %w", err)
Expand Down Expand Up @@ -133,7 +137,7 @@ func NewCmdInstall(provider k8s.Provider) *cobra.Command {
cmd.Flags().StringVarP(&flagPassword, "password", "p", "password", "basic auth password, can also be specified via "+envBasicAuthPass)
cmd.Flags().IntVar(&flagPort, "port", local.Port, "ingress http port")

cmd.Flags().StringVar(&flagHelmChartVersion, "helm-chart-version", "latest", "specify the specific Airbyte helm-chart-version to install")
cmd.Flags().StringVar(&flagChartVersion, "chart-version", "latest", "specify the specific Airbyte helm chart version to install")

return cmd
}

0 comments on commit d91191a

Please sign in to comment.