Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set JOB_MAIN_CONTAINER envs in low-resource-mode #120

Closed
wants to merge 1 commit into from
Closed

fix: set JOB_MAIN_CONTAINER envs in low-resource-mode #120

wants to merge 1 commit into from

Conversation

colesnodgrass
Copy link
Member

  • set the following env-vars to 0 when running in low-resource-mode
    • JOB_MAIN_CONTAINER_CPU_REQUEST
    • JOB_MAIN_CONTAINER_MEMORY_REQUEST

@colesnodgrass colesnodgrass requested a review from a team as a code owner September 17, 2024 23:41
@abuchanan-airbyte
Copy link
Collaborator

abuchanan-airbyte commented Sep 18, 2024 •
edited
Loading

I think these get set via global.jobs.resources.requests:

abctl/internal/cmd/local/local/install.go

Lines 185 to 186 in d70ad70

"global.jobs.resources.limits.cpu=3",
"global.jobs.resources.limits.memory=4Gi",

Would be undoing: https://github.com/airbytehq/abctl/pull/114/files

@colesnodgrass
Copy link
Member Author

You are correct.

@colesnodgrass colesnodgrass deleted the cole/more-low-resource branch September 18, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colesnodgrass @abuchanan-airbyte