Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: note about segment context handling in http request #140

Merged
merged 1 commit into from
Oct 25, 2024
Merged

docs: note about segment context handling in http request #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions internal/telemetry/segment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,8 @@ func (s *SegmentClient) send(ctx context.Context, es EventState, et EventType, e
return fmt.Errorf("unable to create request body: %w", err)
}

// We don't include the parent context in the http request,
// because we want to send telemetry even if the parent context is canceled.
req, err := http.NewRequest(http.MethodPost, url, bytes.NewBuffer(data))
if err != nil {
return fmt.Errorf("unable to create request: %w", err)
Expand Down