Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CustomDbtNormalization on k8s #238

Closed

Conversation

Grayfados
Copy link

@Grayfados Grayfados commented May 8, 2023

Solves the issue 5091 - now, only for bigquery destination.

The purpose of this modifications is to "re-clone" the repo inside the pod if the folder doesn't exists. It reuses the structure of the NormalizationRunner.

At this points it uses a custom script to create the profile of bigquery destination. The better form is to reuse the transform-config script to create the dbt profile (pls someone should help me on that).

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.
Enable CustomDbtNormalization on k8s

How

Describe the solution
Added the NormalizationRunner steps to DbtNormalizationRunner and enforced the creation of git_repo inside the normalization pod.

Recommended reading order

  1. x.java
  2. y.java

Can this PR be safely reverted / rolled back?

If you know that your PR is backwards-compatible and can be simply reverted or rolled back, check the YES box.

Otherwise if your PR has a breaking change, like a database migration for example, check the NO box.

If unsure, leave it blank.

  • YES 💚
  • [] NO ❌

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

pedropinho2022 and others added 3 commits May 8, 2023 17:11
The purpose of this modifications is to "re-clone" the repo inside the pod
if the folder doesn't exists. It reuses the structure of the NormalizationRunner.

At this points it uses a custom script to create the profile of bigquery destination.
The better form is to reuse the transform-config.py script to create the dbt profile.
@Grayfados
Copy link
Author

@davinchia Can this be used?

@elliottrabac
Copy link
Contributor

How can we benefit from this update? We would love to run dbt transformation on k8s.

@anaselmhamdi
Copy link

Small bump on this, would love to have this merged !

@franviera92
Copy link
Contributor

@5ylar
Copy link

5ylar commented Aug 29, 2023

read this Airbyte is going to stop using dbt internally as the tool

@franviera92

Is it true?
Can you re-check the link of Airbyte is going to stop using dbt internally as the tool? I guess your link is not correct.

@nurikk-sa
Copy link

read this Airbyte is going to stop using dbt internally as the tool

@franviera92

Is it true? Can you re-check the link of Airbyte is going to stop using dbt internally as the tool? I guess your link is not correct.

It's for internal usage, dbt invocation and the end of pipeline should still work

airbytehq/airbyte#25194 (comment)

@CLAassistant
Copy link

CLAassistant commented May 7, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ Grayfados
❌ pedropinho2022
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

github-actions bot commented May 7, 2024

Your branch is not currently up-to-date with main. Please update your branch before attempting to snapshot your PR.

@marcosmarxm
Copy link
Member

This feature was deprecated.

Copy link
Contributor

Your branch is not currently up-to-date with main. Please update your branch before attempting to snapshot your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants