-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor & convert
PageTitle
to SCSS (#17139)
* Converts PageTitle from styled components to SCSS. * Delete package-lock.json * Swapped deprecated H3 for Text base component. * Renames and moves the PageTitle component. * Adds primary story. * Removes PageTitle component. * Regenerates failing snapshot tests. * Requested changes.
- Loading branch information
1 parent
0cd1d56
commit 0daa9f2
Showing
20 changed files
with
114 additions
and
104 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
...omponents/PageTitle/PageTitle.module.scss → ...ents/ui/PageHeader/PageHeader.module.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
airbyte-webapp/src/components/ui/PageHeader/PageHeader.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
import classNames from "classnames"; | ||
import React from "react"; | ||
|
||
import { Text } from "components/ui/Text"; | ||
|
||
import styles from "./PageHeader.module.scss"; | ||
|
||
interface PageHeaderProps { | ||
withLine?: boolean; | ||
middleComponent?: React.ReactNode; | ||
middleTitleBlock?: React.ReactNode; | ||
endComponent?: React.ReactNode; | ||
title: React.ReactNode; | ||
} | ||
|
||
export const PageHeader: React.FC<PageHeaderProps> = ({ | ||
title, | ||
withLine, | ||
middleComponent, | ||
middleTitleBlock, | ||
endComponent, | ||
}) => ( | ||
<div className={classNames(styles.container)} data-withLine={withLine}> | ||
<Text | ||
as="h1" | ||
size="md" | ||
className={classNames(styles.start, { | ||
[styles.withLine]: withLine, | ||
})} | ||
> | ||
{title} | ||
</Text> | ||
{middleTitleBlock ? ( | ||
<Text | ||
as="h3" | ||
size="md" | ||
className={classNames(styles.heading, { | ||
[styles.middle]: middleTitleBlock, | ||
})} | ||
> | ||
{middleTitleBlock} | ||
</Text> | ||
) : ( | ||
<div className={classNames(styles.middle)}>{middleComponent}</div> | ||
)} | ||
<div className={classNames(styles.end)}>{endComponent}</div> | ||
</div> | ||
); |
28 changes: 28 additions & 0 deletions
28
airbyte-webapp/src/components/ui/PageHeader/index.stories.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
import { faPlus } from "@fortawesome/free-solid-svg-icons"; | ||
import { FontAwesomeIcon } from "@fortawesome/react-fontawesome"; | ||
import { ComponentStory, ComponentMeta } from "@storybook/react"; | ||
|
||
import { Button } from "../Button"; | ||
import { PageHeader } from "./PageHeader"; | ||
|
||
export default { | ||
title: "UI/PageHeader", | ||
component: PageHeader, | ||
argTypes: {}, | ||
} as ComponentMeta<typeof PageHeader>; | ||
|
||
const Template: ComponentStory<typeof PageHeader> = (args) => <PageHeader {...args} />; | ||
|
||
const title = "Connections"; | ||
|
||
const endComponent = ( | ||
<Button icon={<FontAwesomeIcon icon={faPlus} />} variant="primary" size="sm"> | ||
New Source | ||
</Button> | ||
); | ||
|
||
export const Primary = Template.bind({}); | ||
Primary.args = { | ||
title, | ||
endComponent, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
export * from "./PageHeader"; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.