🐛Destination Google Sheets: Fix empty headers list (#18729)

* Fix empty headers list * Updated PR number * Bumped version * auto-bump connector version Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
airbytehq · Nov 3, 2022 · 10f8c46 · 10f8c46
1 parent 44edd76
commit 10f8c46
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 5 deletions.
diff --git a/airbyte-config/init/src/main/resources/seed/destination_definitions.yaml b/airbyte-config/init/src/main/resources/seed/destination_definitions.yaml
@@ -317,7 +317,7 @@
 - name: Google Sheets
   destinationDefinitionId: a4cbd2d1-8dbe-4818-b8bc-b90ad782d12a
   dockerRepository: airbyte/destination-google-sheets
-  dockerImageTag: 0.1.1
+  dockerImageTag: 0.1.2
   documentationUrl: https://docs.airbyte.com/integrations/destinations/google-sheets
   icon: google-sheets.svg
   releaseStage: alpha

diff --git a/airbyte-config/init/src/main/resources/seed/destination_specs.yaml b/airbyte-config/init/src/main/resources/seed/destination_specs.yaml
@@ -6108,7 +6108,7 @@
     supported_destination_sync_modes:
     - "overwrite"
     - "append"
-- dockerImage: "airbyte/destination-google-sheets:0.1.1"
+- dockerImage: "airbyte/destination-google-sheets:0.1.2"
   spec:
     documentationUrl: "https://docs.airbyte.com/integrations/destinations/google-sheets"
     connectionSpecification:

diff --git a/airbyte-integrations/connectors/destination-google-sheets/Dockerfile b/airbyte-integrations/connectors/destination-google-sheets/Dockerfile
@@ -13,5 +13,5 @@ RUN pip install .
 
 ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
 
-LABEL io.airbyte.version=0.1.1
+LABEL io.airbyte.version=0.1.2
 LABEL io.airbyte.name=airbyte/destination-google-sheets
diff --git a/airbyte-integrations/connectors/destination-google-sheets/README.md b/airbyte-integrations/connectors/destination-google-sheets/README.md
@@ -79,7 +79,7 @@ cat integration_tests/test_data/messages.txt | docker run --rm -v $(pwd)/secrets
    Make sure to familiarize yourself with [pytest test discovery](https://docs.pytest.org/en/latest/goodpractices.html#test-discovery) to know how your test files and methods should be named.
 First install test dependencies into your virtual environment:
 ```
-pip install .[tests]
+pip install .'[tests]'
 ```
 ### Unit Tests
 To run unit tests locally, from the connector directory run:

diff --git a/...ntegrations/connectors/destination-google-sheets/destination_google_sheets/spreadsheet.py b/...ntegrations/connectors/destination-google-sheets/destination_google_sheets/spreadsheet.py
@@ -46,7 +46,8 @@ def set_headers(self, stream_name: str, headers_list: List[str]):
         Sets headers belonging to the input stream
         """
         stream: Worksheet = self.open_worksheet(stream_name)
-        stream.update_row(1, headers_list)
+        if headers_list:
+            stream.update_row(1, headers_list)
 
     def index_cols(self, stream: Worksheet) -> Mapping[str, int]:
         """

diff --git a/docs/integrations/destinations/google-sheets.md b/docs/integrations/destinations/google-sheets.md
@@ -130,5 +130,6 @@ You cannot create more than 200 worksheets within single spreadsheet.
 
 | Version | Date       | Pull Request                                             | Subject                             |
 | ------- | ---------- | -------------------------------------------------------- | ----------------------------------- |
+| 0.1.2   | 2022-10-31 | [18729](https://github.com/airbytehq/airbyte/pull/18729) | Fix empty headers list              |
 | 0.1.1   | 2022-06-15 | [14751](https://github.com/airbytehq/airbyte/pull/14751) | Yield state only when records saved |
 | 0.1.0   | 2022-04-26 | [12135](https://github.com/airbytehq/airbyte/pull/12135) | Initial Release                     |