fix broken assertions for automatic migration tests (#4732)

airbytehq · Jul 13, 2021 · 27ec657 · 27ec657
1 parent 8b45744
commit 27ec657
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 4 deletions.
diff --git a/airbyte-server/src/test/java/io/airbyte/server/migration/RunMigrationTest.java b/airbyte-server/src/test/java/io/airbyte/server/migration/RunMigrationTest.java
@@ -159,7 +159,11 @@ private void assertSourceDefinitions(ConfigRepository configRepository) throws J
     assertEquals("MySQL", mysqlDefinition.getName());
 
     final StandardSourceDefinition postgresDefinition = sourceDefinitions.get("decd338e-5647-4c0b-adf4-da0e75f5a750");
-    assertTrue(postgresDefinition.getDockerImageTag().compareTo("0.3.4") >= 0);
+    String[] tagBrokenAsArray = postgresDefinition.getDockerImageTag().replace(".", ",").split(",");
+    assertEquals(3, tagBrokenAsArray.length);
+    assertTrue(Integer.parseInt(tagBrokenAsArray[0]) >= 0);
+    assertTrue(Integer.parseInt(tagBrokenAsArray[1]) >= 3);
+    assertTrue(Integer.parseInt(tagBrokenAsArray[2]) >= 4);
     assertTrue(postgresDefinition.getName().contains("Postgres"));
   }
 
@@ -178,7 +182,11 @@ private void assertDestinationDefinitions(ConfigRepository configRepository) thr
     assertEquals("0.2.0", localCsvDefinition.getDockerImageTag());
 
     final StandardDestinationDefinition snowflakeDefinition = sourceDefinitions.get("424892c4-daac-4491-b35d-c6688ba547ba");
-    assertTrue(snowflakeDefinition.getDockerImageTag().compareTo("0.3.9") >= 0);
+    String[] tagBrokenAsArray = snowflakeDefinition.getDockerImageTag().replace(".", ",").split(",");
+    assertEquals(3, tagBrokenAsArray.length);
+    assertTrue(Integer.parseInt(tagBrokenAsArray[0]) >= 0);
+    assertTrue(Integer.parseInt(tagBrokenAsArray[1]) >= 3);
+    assertTrue(Integer.parseInt(tagBrokenAsArray[2]) >= 9);
     assertTrue(snowflakeDefinition.getName().contains("Snowflake"));
   }
 

diff --git a/...ptanceTest/java/io/airbyte/test/automaticMigrationAcceptance/MigrationAcceptanceTest.java b/...ptanceTest/java/io/airbyte/test/automaticMigrationAcceptance/MigrationAcceptanceTest.java
@@ -204,7 +204,11 @@ private void assertSourceDefinitionInformation(ApiClient apiClient) throws ApiEx
         foundMysqlSourceDefinition = true;
       } else if (sourceDefinitionRead.getSourceDefinitionId().toString()
           .equals("decd338e-5647-4c0b-adf4-da0e75f5a750")) {
-        assertTrue(sourceDefinitionRead.getDockerImageTag().compareTo("0.3.4") >= 0);
+        String[] tagBrokenAsArray = sourceDefinitionRead.getDockerImageTag().replace(".", ",").split(",");
+        assertEquals(3, tagBrokenAsArray.length);
+        assertTrue(Integer.parseInt(tagBrokenAsArray[0]) >= 0);
+        assertTrue(Integer.parseInt(tagBrokenAsArray[1]) >= 3);
+        assertTrue(Integer.parseInt(tagBrokenAsArray[2]) >= 4);
         assertTrue(sourceDefinitionRead.getName().contains("Postgres"));
         foundPostgresSourceDefinition = true;
       }
@@ -235,7 +239,11 @@ private void assertDestinationDefinitionInformation(ApiClient apiClient) throws
           foundLocalCSVDestinationDefinition = true;
         }
         case "424892c4-daac-4491-b35d-c6688ba547ba" -> {
-          assertTrue(destinationDefinitionRead.getDockerImageTag().compareTo("0.3.9") >= 0);
+          String[] tagBrokenAsArray = destinationDefinitionRead.getDockerImageTag().replace(".", ",").split(",");
+          assertEquals(3, tagBrokenAsArray.length);
+          assertTrue(Integer.parseInt(tagBrokenAsArray[0]) >= 0);
+          assertTrue(Integer.parseInt(tagBrokenAsArray[1]) >= 3);
+          assertTrue(Integer.parseInt(tagBrokenAsArray[2]) >= 9);
           assertTrue(destinationDefinitionRead.getName().contains("Snowflake"));
           foundSnowflakeDestinationDefintion = true;
         }