fix reserved keywords bug and disable dbt

airbytehq · Nov 13, 2021 · 282febe · 282febe
1 parent 856233b
commit 282febe
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 5 deletions.
diff --git a/...ntegrations/bases/base-normalization/normalization/transform_catalog/reserved_keywords.py b/...ntegrations/bases/base-normalization/normalization/transform_catalog/reserved_keywords.py
@@ -2533,7 +2533,9 @@
     "REGR_SYY",
 }
 
-CLICKHOUSE = {}
+# In ClickHouse, keywords are not reserved.
+# Ref: https://clickhouse.com/docs/en/sql-reference/syntax/#syntax-keywords
+CLICKHOUSE = set()
 
 RESERVED_KEYWORDS = {
     DestinationType.BIGQUERY.value: BIGQUERY,

diff --git a/...integrations/destination/clickhouse/ClickhouseDestinationStrictEncryptAcceptanceTest.java b/...integrations/destination/clickhouse/ClickhouseDestinationStrictEncryptAcceptanceTest.java
@@ -50,7 +50,7 @@ protected boolean supportsNormalization() {
 
   @Override
   protected boolean supportsDBT() {
-    return true;
+    return false;
   }
 
   @Override

diff --git a/airbyte-integrations/connectors/destination-clickhouse/src/main/resources/spec.json b/airbyte-integrations/connectors/destination-clickhouse/src/main/resources/spec.json
@@ -2,7 +2,7 @@
   "documentationUrl": "https://docs.airbyte.io/integrations/destinations/clickhouse",
   "supportsIncremental": true,
   "supportsNormalization": true,
-  "supportsDBT": true,
+  "supportsDBT": false,
   "supported_destination_sync_modes": ["overwrite", "append", "append_dedup"],
   "connectionSpecification": {
     "$schema": "http://json-schema.org/draft-07/schema#",

diff --git a/...a/io/airbyte/integrations/destination/clickhouse/ClickhouseDestinationAcceptanceTest.java b/...a/io/airbyte/integrations/destination/clickhouse/ClickhouseDestinationAcceptanceTest.java
@@ -40,7 +40,7 @@ protected boolean supportsNormalization() {
 
   @Override
   protected boolean supportsDBT() {
-    return true;
+    return false;
   }
 
   @Override

diff --git a/...o/airbyte/integrations/destination/clickhouse/SshClickhouseDestinationAcceptanceTest.java b/...o/airbyte/integrations/destination/clickhouse/SshClickhouseDestinationAcceptanceTest.java
@@ -48,7 +48,7 @@ protected boolean supportsNormalization() {
 
   @Override
   protected boolean supportsDBT() {
-    return true;
+    return false;
   }
 
   @Override