🐛 Source google ads: mark custom query fields required (#15858)

* Mark query and table_name as required * Bump version * bypass backward compat tests * bypass backward compat tests * revert change on source-google-sheets/acceptance-test-config * oncall 467 - source google ads: fix sats * oncall #467 source google-ads: one more SATs fix * auto-bump connector version [ci skip] Co-authored-by: alafanechere <augustin.lafanechere@gmail.com> Co-authored-by: Denys Davydov <davydov.den18@gmail.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
airbytehq · Sep 15, 2022 · 2e17e3f · 2e17e3f
1 parent dcce166
commit 2e17e3f
Show file tree

Hide file tree

Showing 8 changed files with 55 additions and 50 deletions.
diff --git a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml
@@ -355,7 +355,7 @@
 - name: Google Ads
   sourceDefinitionId: 253487c0-2246-43ba-a21f-5116b20a2c50
   dockerRepository: airbyte/source-google-ads
-  dockerImageTag: 0.1.45
+  dockerImageTag: 0.2.0
   documentationUrl: https://docs.airbyte.io/integrations/sources/google-ads
   icon: google-adwords.svg
   sourceType: api

diff --git a/airbyte-config/init/src/main/resources/seed/source_specs.yaml b/airbyte-config/init/src/main/resources/seed/source_specs.yaml
@@ -3318,7 +3318,7 @@
     supportsNormalization: false
     supportsDBT: false
     supported_destination_sync_modes: []
-- dockerImage: "airbyte/source-google-ads:0.1.45"
+- dockerImage: "airbyte/source-google-ads:0.2.0"
   spec:
     documentationUrl: "https://docs.airbyte.com/integrations/sources/google-ads"
     connectionSpecification:
@@ -3418,6 +3418,9 @@
           order: 3
           items:
             type: "object"
+            required:
+            - "query"
+            - "table_name"
             properties:
               query:
                 type: "string"

diff --git a/airbyte-integrations/connectors/source-google-ads/Dockerfile b/airbyte-integrations/connectors/source-google-ads/Dockerfile
@@ -13,5 +13,5 @@ COPY main.py ./
 
 ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
 
-LABEL io.airbyte.version=0.1.45
+LABEL io.airbyte.version=0.2.0
 LABEL io.airbyte.name=airbyte/source-google-ads
diff --git a/airbyte-integrations/connectors/source-google-ads/acceptance-test-config.yml b/airbyte-integrations/connectors/source-google-ads/acceptance-test-config.yml
@@ -4,6 +4,8 @@ connector_image: airbyte/source-google-ads:dev
 tests:
   spec:
     - spec_path: "source_google_ads/spec.json"
+      backward_compatibility_tests_config:
+        disable_for_version: "0.1.45"
   connection:
     - config_path: "secrets/config.json"
       status: "succeed"

diff --git a/airbyte-integrations/connectors/source-google-ads/integration_tests/test_incremental.py b/airbyte-integrations/connectors/source-google-ads/integration_tests/test_incremental.py
@@ -37,7 +37,7 @@ def test_incremental_sync(config, configured_catalog):
     today = pendulum.now().date()
     start_date = today.subtract(months=3)
     config["start_date"] = start_date.to_date_string()
-
+    config.pop("end_date", "")
     google_ads_client = SourceGoogleAds()
     records = list(google_ads_client.read(logging.getLogger("airbyte"), config, ConfiguredAirbyteCatalog.parse_obj(configured_catalog)))
     latest_state = None

diff --git a/airbyte-integrations/connectors/source-google-ads/source_google_ads/spec.json b/airbyte-integrations/connectors/source-google-ads/source_google_ads/spec.json
@@ -86,6 +86,7 @@
         "order": 3,
         "items": {
           "type": "object",
+          "required": ["query", "table_name"],
           "properties": {
             "query": {
               "type": "string",

diff --git a/airbyte-integrations/connectors/source-google-sheets/acceptance-test-config.yml b/airbyte-integrations/connectors/source-google-sheets/acceptance-test-config.yml
@@ -24,5 +24,3 @@ tests:
   full_refresh:
     - config_path: "secrets/service_config.json"
       configured_catalog_path: "integration_tests/configured_catalog.json"
-
-
diff --git a/docs/integrations/sources/google-ads.md b/docs/integrations/sources/google-ads.md