Skip to content

Commit

Permalink
🐛 Source Pardot: failed while syncing Visitors stream (#19618)
Browse files Browse the repository at this point in the history
* Update the kw-only argument

* Update pardot version

* fix: address review changes

* fix: update source.py to pass flakeCheck

* fix: delete incomplete test

* auto-bump connector version

Co-authored-by: Sajarin <sajarindider@gmail.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
  • Loading branch information
3 people authored Dec 15, 2022
1 parent 2a44db6 commit 32015af
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 23 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1135,7 +1135,7 @@
- name: Pardot
sourceDefinitionId: ad15c7ba-72a7-440b-af15-b9a963dc1a8a
dockerRepository: airbyte/source-pardot
dockerImageTag: 0.1.0
dockerImageTag: 0.1.1
documentationUrl: https://docs.airbyte.com/integrations/sources/pardot
sourceType: api
releaseStage: alpha
Expand Down
4 changes: 2 additions & 2 deletions airbyte-config/init/src/main/resources/seed/source_specs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10509,9 +10509,9 @@
supportsNormalization: false
supportsDBT: false
supported_destination_sync_modes: []
- dockerImage: "airbyte/source-pardot:0.1.0"
- dockerImage: "airbyte/source-pardot:0.1.1"
spec:
documentationUrl: "https://docsurl.com"
documentationUrl: "https://docs.airbyte.com/integrations/sources/pardot"
connectionSpecification:
$schema: "http://json-schema.org/draft-07/schema#"
title: "Pardot Spec"
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-pardot/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,5 @@ COPY source_pardot ./source_pardot
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.0
LABEL io.airbyte.version=0.1.1
LABEL io.airbyte.name=airbyte/source-pardot
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ def streams(self, config: Mapping[str, Any]) -> List[Stream]:
auth = TokenAuthenticator(pardot.access_token)
args = {"authenticator": auth, "config": config}

visitors = Visitors(**args)

return [
EmailClicks(**args),
Campaigns(**args),
Expand All @@ -45,6 +43,6 @@ def streams(self, config: Mapping[str, Any]) -> List[Stream]:
Prospects(**args),
Users(**args),
VisitorActivities(**args),
visitors,
Visits(parent_stream=visitors, **args),
Visitors(**args),
Visits(parent_stream=Visitors(**args), **args),
]
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"documentationUrl": "https://docsurl.com",
"documentationUrl": "https://docs.airbyte.com/integrations/sources/pardot",
"connectionSpecification": {
"$schema": "http://json-schema.org/draft-07/schema#",
"title": "Pardot Spec",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ class Visitors(PardotUpdatedAtReplicationStream):
def stream_slices(
self, sync_mode: SyncMode, cursor_field: List[str] = None, stream_state: Mapping[str, Any] = None
) -> Iterable[Optional[Mapping[str, Any]]]:
slices = super().stream_slices(sync_mode, cursor_field=cursor_field, stream_state=stream_state)
slices = super().stream_slices(sync_mode=sync_mode, cursor_field=cursor_field, stream_state=stream_state)
return slices


Expand Down

This file was deleted.

0 comments on commit 32015af

Please sign in to comment.