Source Amazon Ads: added adId to product report stream (#11660)

* added adId to product report stream * simplified removal of adId * removed duplicate comment * Bumped dockerfile version * bump connector version Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
airbytehq · Apr 26, 2022 · 3414656 · 3414656
1 parent 8dc704f
commit 3414656
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 3 deletions.
diff --git a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml
@@ -15,7 +15,7 @@
 - name: Amazon Ads
   sourceDefinitionId: c6b0a29e-1da9-4512-9002-7bfd0cba2246
   dockerRepository: airbyte/source-amazon-ads
-  dockerImageTag: 0.1.5
+  dockerImageTag: 0.1.6
   documentationUrl: https://docs.airbyte.io/integrations/sources/amazon-ads
   icon: amazonads.svg
   sourceType: api

diff --git a/airbyte-config/init/src/main/resources/seed/source_specs.yaml b/airbyte-config/init/src/main/resources/seed/source_specs.yaml
@@ -87,7 +87,7 @@
     supportsNormalization: false
     supportsDBT: false
     supported_destination_sync_modes: []
-- dockerImage: "airbyte/source-amazon-ads:0.1.5"
+- dockerImage: "airbyte/source-amazon-ads:0.1.6"
   spec:
     documentationUrl: "https://docs.airbyte.io/integrations/sources/amazon-ads"
     connectionSpecification:

diff --git a/airbyte-integrations/connectors/source-amazon-ads/Dockerfile b/airbyte-integrations/connectors/source-amazon-ads/Dockerfile
@@ -12,5 +12,5 @@ RUN pip install .
 ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
 ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
 
-LABEL io.airbyte.version=0.1.5
+LABEL io.airbyte.version=0.1.6
 LABEL io.airbyte.name=airbyte/source-amazon-ads
diff --git a/.../connectors/source-amazon-ads/source_amazon_ads/streams/report_streams/products_report.py b/.../connectors/source-amazon-ads/source_amazon_ads/streams/report_streams/products_report.py
@@ -119,6 +119,7 @@
         "campaignId",
         "adGroupName",
         "adGroupId",
+        "adId",
         "impressions",
         "clicks",
         "cost",
@@ -156,6 +157,7 @@
         "adGroupId",
         "keywordId",
         "keywordText",
+        "adId",
         "asin",
         "otherAsin",
         "sku",
@@ -179,6 +181,7 @@
         "campaignId",
         "adGroupName",
         "adGroupId",
+        "adId",
         "asin",
         "otherAsin",
         "sku",
@@ -262,4 +265,9 @@ def _get_init_report_body(self, report_date: str, record_type: str, profile):
             if profile.accountInfo.type == "vendor":
                 metrics_list = copy(metrics_list)
                 metrics_list.remove("sku")
+
+# adId is automatically added to the report by amazon and requesting adId causes an amazon error
+        if "adId" in metrics_list:
+            metrics_list.remove("adId")
+
         return {**body, "metrics": ",".join(metrics_list)}
diff --git a/docs/integrations/sources/amazon-ads.md b/docs/integrations/sources/amazon-ads.md
@@ -76,6 +76,7 @@ Start date used for generating reports starting from the specified start date. S
 
 | Version | Date | Pull Request | Subject |
 | :--- | :--- | :--- | :--- |
+| `0.1.6` | 2022-04-20 | [\#11659](https://github.com/airbytehq/airbyte/pull/11659) | Add adId to products report |
 | `0.1.5` | 2022-04-08 | [\#11430](https://github.com/airbytehq/airbyte/pull/11430) | `Added support OAuth2.0` |
 | `0.1.4` | 2022-02-21 | [\#10513](https://github.com/airbytehq/airbyte/pull/10513) | `Increasing REPORT_WAIT_TIMEOUT for supporting report generation which takes longer time ` |
 | `0.1.3` | 2021-12-28 | [\#8388](https://github.com/airbytehq/airbyte/pull/8388) | `Add retry if recoverable error  occured for reporting stream processing` |