🐛 Source Google Ads: Fix wrong schema for `ad_group_criterion.topic.p…

…ath` and shifted `Campaigns` stream to non-managers stream list (#15084) * Fix wrong schema for ad_group_criterion.topic.path * Shifted campaingns stream to non-manager streams * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
airbytehq · Jul 28, 2022 · 39029f8 · 39029f8
1 parent 22c107a
commit 39029f8
Show file tree

Hide file tree

Showing 6 changed files with 53 additions and 49 deletions.
diff --git a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml
@@ -327,7 +327,7 @@
 - name: Google Ads
   sourceDefinitionId: 253487c0-2246-43ba-a21f-5116b20a2c50
   dockerRepository: airbyte/source-google-ads
-  dockerImageTag: 0.1.43
+  dockerImageTag: 0.1.44
   documentationUrl: https://docs.airbyte.io/integrations/sources/google-ads
   icon: google-adwords.svg
   sourceType: api

diff --git a/airbyte-config/init/src/main/resources/seed/source_specs.yaml b/airbyte-config/init/src/main/resources/seed/source_specs.yaml
@@ -2798,7 +2798,7 @@
     supportsNormalization: false
     supportsDBT: false
     supported_destination_sync_modes: []
-- dockerImage: "airbyte/source-google-ads:0.1.43"
+- dockerImage: "airbyte/source-google-ads:0.1.44"
   spec:
     documentationUrl: "https://docs.airbyte.com/integrations/sources/google-ads"
     connectionSpecification:

diff --git a/airbyte-integrations/connectors/source-google-ads/Dockerfile b/airbyte-integrations/connectors/source-google-ads/Dockerfile
@@ -13,5 +13,5 @@ COPY main.py ./
 
 ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
 
-LABEL io.airbyte.version=0.1.43
+LABEL io.airbyte.version=0.1.44
 LABEL io.airbyte.name=airbyte/source-google-ads
diff --git a/...ectors/source-google-ads/source_google_ads/schemas/display_topics_performance_report.json b/...ectors/source-google-ads/source_google_ads/schemas/display_topics_performance_report.json
@@ -126,7 +126,10 @@
       "type": ["null", "string"]
     },
     "ad_group_criterion.topic.path": {
-      "type": ["null", "string"]
+      "type": ["null", "array"],
+      "items": {
+        "type": "string"
+      }
     },
     "metrics.cross_device_conversions": {
       "type": ["null", "number"]

diff --git a/airbyte-integrations/connectors/source-google-ads/source_google_ads/source.py b/airbyte-integrations/connectors/source-google-ads/source_google_ads/source.py
@@ -121,14 +121,14 @@ def streams(self, config: Mapping[str, Any]) -> List[Stream]:
             AdGroups(**incremental_config),
             AdGroupLabels(google_api, customers=customers),
             Accounts(**incremental_config),
-            Campaigns(**incremental_config),
             CampaignLabels(google_api, customers=customers),
             ClickView(**incremental_config),
         ]
         # Metrics streams cannot be requested for a manager account.
         if non_manager_accounts:
             streams.extend(
                 [
+                    Campaigns(**non_manager_incremental_config),
                     UserLocationReport(**non_manager_incremental_config),
                     AccountPerformanceReport(**non_manager_incremental_config),
                     DisplayTopicsPerformanceReport(**non_manager_incremental_config),