remove validation from source delete (#8724)

airbytehq · Dec 16, 2021 · 3a69029 · 3a69029
1 parent 2ad4ca1
commit 3a69029
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/.../io/airbyte/integrations/destination/buffered_stream_consumer/BufferedStreamConsumer.java b/.../io/airbyte/integrations/destination/buffered_stream_consumer/BufferedStreamConsumer.java
@@ -146,7 +146,7 @@ protected void acceptTracked(final AirbyteMessage message) throws Exception {
       // TODO use a more efficient way to compute bytes that doesn't require double serialization (records
       // are serialized again when writing to
       // the destination
-      long messageSizeInBytes = ByteUtils.getSizeInBytes(Jsons.serialize(recordMessage.getData()));
+      final long messageSizeInBytes = ByteUtils.getSizeInBytes(Jsons.serialize(recordMessage.getData()));
       if (bufferSizeInBytes + messageSizeInBytes >= maxQueueSizeInBytes) {
         flushQueueToDestination();
         bufferSizeInBytes = 0;
@@ -202,7 +202,7 @@ protected void close(final boolean hasFailed) throws Exception {
     }
 
     try {
-      // if no state was was emitted (i.e. full refresh), if there were still no failures, then we can
+      // if no state was emitted (i.e. full refresh), if there were still no failures, then we can
       // still succeed.
       if (lastFlushedState == null) {
         onClose.accept(hasFailed);
@@ -211,7 +211,7 @@ protected void close(final boolean hasFailed) throws Exception {
         onClose.accept(false);
       }
 
-      // if one close succeeds without exception then we can emit the state record because it means its
+      // if onClose succeeds without exception then we can emit the state record because it means its
       // records were not only flushed, but committed.
       if (lastFlushedState != null) {
         outputRecordCollector.accept(lastFlushedState);

diff --git a/airbyte-server/src/main/java/io/airbyte/server/handlers/DestinationHandler.java b/airbyte-server/src/main/java/io/airbyte/server/handlers/DestinationHandler.java
@@ -101,7 +101,7 @@ public void deleteDestination(final DestinationIdRequestBody destinationIdReques
   public void deleteDestination(final DestinationRead destination)
       throws JsonValidationException, IOException, ConfigNotFoundException {
     // disable all connections associated with this destination
-    // Delete connections first in case it it fails in the middle, destination will still be visible
+    // Delete connections first in case it fails in the middle, destination will still be visible
     final WorkspaceIdRequestBody workspaceIdRequestBody = new WorkspaceIdRequestBody().workspaceId(destination.getWorkspaceId());
     for (final ConnectionRead connectionRead : connectionsHandler.listConnectionsForWorkspace(workspaceIdRequestBody).getConnections()) {
       if (!connectionRead.getDestinationId().equals(destination.getDestinationId())) {

diff --git a/airbyte-server/src/main/java/io/airbyte/server/handlers/SourceHandler.java b/airbyte-server/src/main/java/io/airbyte/server/handlers/SourceHandler.java
@@ -157,7 +157,7 @@ public void deleteSource(final SourceIdRequestBody sourceIdRequestBody)
   public void deleteSource(final SourceRead source)
       throws JsonValidationException, IOException, ConfigNotFoundException {
     // "delete" all connections associated with source as well.
-    // Delete connections first in case it it fails in the middle, source will still be visible
+    // Delete connections first in case it fails in the middle, source will still be visible
     final WorkspaceIdRequestBody workspaceIdRequestBody = new WorkspaceIdRequestBody()
         .workspaceId(source.getWorkspaceId());
     for (final ConnectionRead connectionRead : connectionsHandler
@@ -170,10 +170,7 @@ public void deleteSource(final SourceRead source)
     }
 
     final ConnectorSpecification spec = getSpecFromSourceId(source.getSourceId());
-    validateSource(spec, source.getConnectionConfiguration());
-
     final var fullConfig = configRepository.getSourceConnectionWithSecrets(source.getSourceId()).getConfiguration();
-    validateSource(spec, fullConfig);
 
     // persist
     persistSourceConnection(