store env-var response (#21327)

* store env-var response * fix formatting * fix pmd issue * change log message to debug * fix file change error
airbytehq · Jan 12, 2023 · 440a5e4 · 440a5e4
1 parent c6b8279
commit 440a5e4
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/airbyte-commons-worker/src/main/java/io/airbyte/workers/internal/DefaultAirbyteSource.java b/airbyte-commons-worker/src/main/java/io/airbyte/workers/internal/DefaultAirbyteSource.java
@@ -56,7 +56,7 @@ public class DefaultAirbyteSource implements AirbyteSource {
   private Process sourceProcess = null;
   private Iterator<AirbyteMessage> messageIterator = null;
   private Integer exitValue = null;
-  private final FeatureFlags featureFlags;
+  private final boolean featureFlagLogConnectorMsgs;
 
   public DefaultAirbyteSource(final IntegrationLauncher integrationLauncher, final FeatureFlags featureFlags) {
     this(integrationLauncher, new DefaultAirbyteStreamFactory(CONTAINER_LOG_MDC_BUILDER), featureFlags);
@@ -76,7 +76,7 @@ public DefaultAirbyteSource(final IntegrationLauncher integrationLauncher,
     this.integrationLauncher = integrationLauncher;
     this.streamFactory = streamFactory;
     this.heartbeatMonitor = heartbeatMonitor;
-    this.featureFlags = featureFlags;
+    this.featureFlagLogConnectorMsgs = featureFlags.logConnectorMessages();
   }
 
   @Trace(operationName = WORKER_OPERATION_NAME)
@@ -171,7 +171,7 @@ public void cancel() throws Exception {
   }
 
   private void logInitialStateAsJSON(final WorkerSourceConfig sourceConfig) {
-    if (!featureFlags.logConnectorMessages()) {
+    if (!featureFlagLogConnectorMsgs) {
       return;
     }
 

diff --git a/...-worker/src/main/java/io/airbyte/workers/internal/book_keeping/AirbyteMessageTracker.java b/...-worker/src/main/java/io/airbyte/workers/internal/book_keeping/AirbyteMessageTracker.java
@@ -67,6 +67,7 @@ public class AirbyteMessageTracker implements MessageTracker {
   private final List<AirbyteTraceMessage> sourceErrorTraceMessages;
   private final StateAggregator stateAggregator;
   private final FeatureFlags featureFlags;
+  private final boolean featureFlagLogConnectorMsgs;
 
   // These variables support SYNC level estimates and are meant for sources where stream level
   // estimates are not possible e.g. CDC sources.
@@ -118,6 +119,7 @@ protected AirbyteMessageTracker(final StateDeltaTracker stateDeltaTracker,
     this.sourceErrorTraceMessages = new ArrayList<>();
     this.stateAggregator = stateAggregator;
     this.featureFlags = featureFlags;
+    this.featureFlagLogConnectorMsgs = featureFlags.logConnectorMessages();
   }
 
   @Trace(operationName = WORKER_OPERATION_NAME)
@@ -545,7 +547,7 @@ public Boolean getUnreliableStateTimingMetrics() {
   }
 
   private void logMessageAsJSON(final String caller, final AirbyteMessage message) {
-    if (!featureFlags.logConnectorMessages()) {
+    if (!featureFlagLogConnectorMsgs) {
       return;
     }
 

diff --git a/airbyte-commons/src/main/java/io/airbyte/commons/features/EnvVariableFeatureFlags.java b/airbyte-commons/src/main/java/io/airbyte/commons/features/EnvVariableFeatureFlags.java
@@ -70,7 +70,7 @@ public <T> T getEnvOrDefault(final String key, final T defaultValue, final Funct
     if (value != null && !value.isEmpty()) {
       return parser.apply(value);
     } else {
-      log.info("Using default value for environment variable {}: '{}'", key, defaultValue);
+      log.debug("Using default value for environment variable {}: '{}'", key, defaultValue);
       return defaultValue;
     }
   }

diff --git a/airbyte-config/init/src/main/resources/seed/destination_definitions.yaml b/airbyte-config/init/src/main/resources/seed/destination_definitions.yaml
@@ -441,4 +441,4 @@
   dockerRepository: airbyte/destination-weaviate
   dockerImageTag: 0.1.0
   documentationUrl: https://docs.airbyte.com/integrations/destinations/weaviate
-  releaseStage: alpha
+  releaseStage: alpha