Skip to content

Commit

Permalink
remove sleep and repeat test to check non flakyness (#19454)
Browse files Browse the repository at this point in the history
* remove sleep and repeat test to check non flakyness

* Remove repeated test
  • Loading branch information
benmoriceau authored Nov 16, 2022
1 parent 05c99c1 commit 651988d
Showing 1 changed file with 0 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -688,9 +688,6 @@ void testDeleteConnection() throws Exception {
// connectionIds.remove(connectionId); // todo remove
testHarness.removeConnection(connectionId);

LOGGER.info("Waiting for connection to be deleted...");
Thread.sleep(5000);

ConnectionStatus connectionStatus =
apiClient.getConnectionApi().getConnection(new ConnectionIdRequestBody().connectionId(connectionId)).getStatus();
assertEquals(ConnectionStatus.DEPRECATED, connectionStatus);
Expand All @@ -710,9 +707,6 @@ void testDeleteConnection() throws Exception {
// we should still be able to delete the connection when the temporal workflow is in this state
apiClient.getConnectionApi().deleteConnection(new ConnectionIdRequestBody().connectionId(connectionId));

LOGGER.info("Waiting for connection to be deleted...");
Thread.sleep(5000);

connectionStatus = apiClient.getConnectionApi().getConnection(new ConnectionIdRequestBody().connectionId(connectionId)).getStatus();
assertEquals(ConnectionStatus.DEPRECATED, connectionStatus);
}
Expand Down

0 comments on commit 651988d

Please sign in to comment.