Fix numerous create calls (#7659)

airbytehq · Nov 5, 2021 · 7fd1804 · 7fd1804
1 parent 56db806
commit 7fd1804
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 10 deletions.
diff --git a/airbyte-webapp/src/packages/cloud/services/auth/AuthService.tsx b/airbyte-webapp/src/packages/cloud/services/auth/AuthService.tsx
@@ -29,7 +29,7 @@ export type AuthConfirmPasswordReset = (
 export type AuthLogin = (values: {
   email: string;
   password: string;
-}) => Promise<User | null>;
+}) => Promise<void>;
 
 export type AuthSignUp = (form: {
   email: string;
@@ -77,7 +77,7 @@ export const AuthenticationProvider: React.FC = ({ children }) => {
   const authService = useMemo(() => new GoogleAuthService(() => auth), [auth]);
 
   useEffect(() => {
-    auth.onAuthStateChanged(async (currentUser) => {
+    return auth.onAuthStateChanged(async (currentUser) => {
       if (state.currentUser === null && currentUser) {
         // token = await currentUser.getIdToken();
 
@@ -115,13 +115,8 @@ export const AuthenticationProvider: React.FC = ({ children }) => {
       inited: state.inited,
       isLoading: state.loading,
       emailVerified: state.emailVerified,
-      async login(values: {
-        email: string;
-        password: string;
-      }): Promise<User | null> {
+      async login(values: { email: string; password: string }): Promise<void> {
         await authService.login(values.email, values.password);
-
-        return null;
       },
       async logout(): Promise<void> {
         await authService.signOut();

diff --git a/airbyte-webapp/src/packages/cloud/views/auth/LoginPage/LoginPage.tsx b/airbyte-webapp/src/packages/cloud/views/auth/LoginPage/LoginPage.tsx
@@ -36,12 +36,12 @@ const LoginPage: React.FC = () => {
           password: "",
         }}
         validationSchema={LoginPageValidationSchema}
-        onSubmit={async (values, { setFieldError, setStatus }) =>
+        onSubmit={async (values, { setFieldError }) =>
           login(values).catch((err) => {
             if (err instanceof FieldError) {
               setFieldError(err.field, err.message);
             } else {
-              setStatus(err.message);
+              setFieldError("password", err.message);
             }
           })
         }