🎉 Google Analytics connector is failing (#3648)

* added filter of streams and deleted duplicated title in spec.json

* fixed discover returns empty streams

* pr changes

* chmod on files changed

* chmod on files changed

* chmod on files changed

* added acceptance tests

* added pre commit config

* fixed chmod on amazon and facebook files

* fixed chmod on amazon and facebook files

* version bump

* version bump

* build file fix

* removed unrelated files

* removed unrelated files

* removed unrelated files

* removed unrelated files

* removed unrelated files

* removed unrelated files

airbyte-config/init/src/main/resources/config/STANDARD_SOURCE_DEFINITION/39f092a6-8c87-4f6f-a8d9-5cef45b7dbe1.json

@@ -2,7 +2,7 @@
   "sourceDefinitionId": "39f092a6-8c87-4f6f-a8d9-5cef45b7dbe1",
   "name": "Google Analytics",
   "dockerRepository": "airbyte/source-googleanalytics-singer",
-  "dockerImageTag": "0.2.4",
+  "dockerImageTag": "0.2.5",
   "documentationUrl": "https://hub.docker.com/r/airbyte/source-googleanalytics-singer",
   "icon": "google-analytics.svg"
 }

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

@@ -100,7 +100,7 @@
 - sourceDefinitionId: 39f092a6-8c87-4f6f-a8d9-5cef45b7dbe1
   name: Google Analytics
   dockerRepository: airbyte/source-googleanalytics-singer
-  dockerImageTag: 0.2.4
+  dockerImageTag: 0.2.5
   documentationUrl: https://hub.docker.com/r/airbyte/source-googleanalytics-singer
   icon: google-analytics.svg
 - sourceDefinitionId: e7778cfc-e97c-4458-9ecb-b4f2bba8946c

airbyte-integrations/connectors/source-googleanalytics-singer/Dockerfile

@@ -8,7 +8,7 @@ ENV CODE_PATH="source_googleanalytics_singer"
 ENV AIRBYTE_IMPL_MODULE="source_googleanalytics_singer"
 ENV AIRBYTE_IMPL_PATH="GoogleAnalyticsSingerSource"
 
-LABEL io.airbyte.version=0.2.4
+LABEL io.airbyte.version=0.2.5
 LABEL io.airbyte.name=airbyte/source-googleanalytics-singer
 
 WORKDIR /airbyte/integration_code

airbyte-integrations/connectors/source-googleanalytics-singer/acceptance-test-config.yml

@@ -0,0 +1,27 @@
+connector_image: airbyte/source-googleanalytics-singer:dev
+tests:
+  spec:
+    - spec_path: "source_googleanalytics_singer/spec.json"
+  connection:
+    - config_path: "secrets/config.json"
+      status: "succeed"
+    - config_path: "integration_tests/invalid_config.json"
+      status: "failed"
+  discovery:
+    - config_path: "secrets/config.json"
+  basic_read:
+    - config_path: "secrets/config.json"
+      configured_catalog_path: "sample_files/configured_catalog.json"
+      validate_output_from_all_streams: yes
+# Commented out due to the state structure is not supported by the SAT
+#  incremental:
+#    - config_path: "secrets/config.json"
+#      configured_catalog_path: "sample_files/configured_catalog.json"
+#      future_state_path: "sample_files/abnormal_state.json"
+#      cursor_paths:
+#        website_overview: ["report_start_date"]
+#        traffic_sources: ["report_start_date"]
+#        pages: ["report_start_date"]
+  full_refresh:
+    - config_path: "secrets/config.json"
+      configured_catalog_path: "integration_tests/configured_catalog.json"

airbyte-integrations/connectors/source-googleanalytics-singer/build.gradle

@@ -1,7 +1,7 @@
 plugins {
     id 'airbyte-python'
     id 'airbyte-docker'
-    id 'airbyte-standard-source-test-file'
+    id 'airbyte-source-acceptance-test'
 }
 
 airbytePython {
@@ -10,10 +10,11 @@ airbytePython {
 
 
 dependencies {
-    implementation files(project(':airbyte-integrations:bases:base-standard-source-test-file').airbyteDocker.outputs)
     implementation files(project(':airbyte-integrations:bases:base-singer').airbyteDocker.outputs)
+    implementation files(project(':airbyte-integrations:bases:source-acceptance-test').airbyteDocker.outputs)
 }
 
+
 // TODO(sherifnada) re-enable tests. Currently they're disabled because they hog up so much bandwidth that they prevent local iteration at times. 
 // airbyteStandardSourceTestFile {
 //    specPath = "source_googleanalytics_singer/spec.json"

airbyte-integrations/connectors/source-googleanalytics-singer/integration_tests/acceptance.py

@@ -0,0 +1,36 @@
+#
+# MIT License
+#
+# Copyright (c) 2020 Airbyte
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the "Software"), to deal
+# in the Software without restriction, including without limitation the rights
+# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+# copies of the Software, and to permit persons to whom the Software is
+# furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included in all
+# copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+# SOFTWARE.
+#
+
+
+import pytest
+
+pytest_plugins = ("source_acceptance_test.plugin",)
+
+
+@pytest.fixture(scope="session", autouse=True)
+def connector_setup():
+    """This fixture is a placeholder for external resources that acceptance test might require."""
+    # TODO: setup test dependencies
+    yield
+    # TODO: clean up test dependencies