🐛 set default value for StandardDestination/SourceDefinition `tombsto…

…ne` fields (#16626)

* [RemoteDefinitionsProvider] set tombstone field on returned definitions

* move patching logic to definitions helper, add test

* roll it back

* set defaults for tombstone field

* format

airbyte-config/config-models/src/main/resources/types/StandardDestinationDefinition.yaml

@@ -30,10 +30,10 @@ properties:
     type: object
     existingJavaType: io.airbyte.protocol.models.ConnectorSpecification
   tombstone:
-    description:
-      if not set or false, the configuration is active. if true, then this
+    description: if false, the configuration is active. if true, then this
       configuration is permanently off.
     type: boolean
+    default: false
   public:
     description: true if this connector definition is available to all workspaces
     type: boolean

airbyte-config/config-models/src/main/resources/types/StandardSourceDefinition.yaml

@@ -37,10 +37,10 @@ properties:
     type: object
     existingJavaType: io.airbyte.protocol.models.ConnectorSpecification
   tombstone:
-    description:
-      if not set or false, the configuration is active. if true, then this
+    description: if false, the configuration is active. if true, then this
       configuration is permanently off.
     type: boolean
+    default: false
   public:
     description: true if this connector definition is available to all workspaces
     type: boolean

airbyte-config/init/src/main/java/io/airbyte/config/init/RemoteDefinitionsProvider.java

@@ -53,7 +53,7 @@ public void initialize() throws InterruptedException, IOException {
         source -> source));
     this.destinationDefinitions = catalog.getDestinations().stream().collect(Collectors.toMap(
         StandardDestinationDefinition::getDestinationDefinitionId,
-        source -> source));
+        destination -> destination));
   }
 
   @Override

airbyte-config/init/src/test/java/io/airbyte/config/init/RemoteDefinitionsProviderTest.java

@@ -61,6 +61,7 @@ void testGetSourceDefinition() throws Exception {
     assertEquals("https://docs.airbyte.io/integrations/sources/stripe", stripeSource.getDocumentationUrl());
     assertEquals("stripe.svg", stripeSource.getIcon());
     assertEquals(URI.create("https://docs.airbyte.io/integrations/sources/stripe"), stripeSource.getSpec().getDocumentationUrl());
+    assertEquals(false, stripeSource.getTombstone());
   }
 
   @Test
@@ -76,6 +77,7 @@ void testGetDestinationDefinition() throws Exception {
     assertEquals("airbyte/destination-s3", s3Destination.getDockerRepository());
     assertEquals("https://docs.airbyte.io/integrations/destinations/s3", s3Destination.getDocumentationUrl());
     assertEquals(URI.create("https://docs.airbyte.io/integrations/destinations/s3"), s3Destination.getSpec().getDocumentationUrl());
+    assertEquals(false, s3Destination.getTombstone());
   }
 
   @Test