-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Misc Improvements to assist Connection Form Refactor (#16303)
* Move exports to declaration for formConfig * Add ConnectionOrPartialConnection, move ConnectionForm exports * Removing additionBottomControls as it was unused * Create and use FormError, test createFormErrorMessage * Remove unnecessary eslint ignore, remove unnecessary async/await * rename createFormErrorMessage
- Loading branch information
1 parent
42c5265
commit a686508
Showing
16 changed files
with
102 additions
and
106 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
import { generateMessageFromError, FormError } from "./errorStatusMessage"; | ||
|
||
describe("#errorStatusMessage", () => { | ||
it("should return a provided error message", () => { | ||
const errMsg = "test"; | ||
expect(generateMessageFromError(new Error(errMsg))).toBe(errMsg); | ||
}); | ||
|
||
it("should return null if no error message and no status, or status is 0", () => { | ||
expect(generateMessageFromError(new Error())).toBe(null); | ||
const fakeStatusError = new FormError(); | ||
fakeStatusError.status = 0; | ||
expect(generateMessageFromError(fakeStatusError)).toBe(null); | ||
}); | ||
|
||
it("should return a validation error message if status is 400", () => { | ||
const fakeStatusError = new FormError(); | ||
fakeStatusError.status = 400; | ||
expect(generateMessageFromError(fakeStatusError)).toMatchInlineSnapshot(` | ||
<Memo(MemoizedFormattedMessage) | ||
id="form.validationError" | ||
/> | ||
`); | ||
}); | ||
|
||
it("should return a 'some error' message if status is > 0 and not 400", () => { | ||
const fakeStatusError = new FormError(); | ||
fakeStatusError.status = 401; | ||
expect(generateMessageFromError(fakeStatusError)).toMatchInlineSnapshot(` | ||
<Memo(MemoizedFormattedMessage) | ||
id="form.someError" | ||
/> | ||
`); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.