Skip to content

Commit

Permalink
New Connector CallRail + format (#19407)
Browse files Browse the repository at this point in the history
* init

* adding image and call rail record within source_definitions.yaml

* replacing data types in users.json

* converting text_messages.json  to conversations.json

* removing trackers.json

* renaming streams in abnormal_state.json and seperating incremental from non-incremental streams in caatalog files

* - moving stream slicer to retriever in definition
- renaming text_messages to conversations

* adding doc for callrail.md

* adjusting sepc.yaml based off of Marcos's comments.

* adjusting sepc.yaml

* cleaning up acceptance-test-config.
small adjustments to rest of files.

* adding pagination

* fix tests

* generate source spec

* solve conflict source spec and def

Co-authored-by: adhamsuliman <adhamsuliman93@gmail.com>
  • Loading branch information
marcosmarxm and asuliman17 authored Nov 16, 2022
1 parent b4dfbdb commit a7ec584
Show file tree
Hide file tree
Showing 29 changed files with 875 additions and 0 deletions.
1 change: 1 addition & 0 deletions airbyte-config/init/src/main/resources/icons/callrail.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,14 @@
documentationUrl: https://docs.airbyte.com/integrations/sources/breezometer
sourceType: api
releaseStage: alpha
- name: CallRail
sourceDefinitionId: dc98a6ad-2dd1-47b6-9529-2ec35820f9c6
dockerRepository: airbyte/source-callrail
dockerImageTag: 0.1.0
documentationUrl: https://docs.airbyte.com/integrations/sources/callrail
icon: callrail.svg
sourceType: api
releaseStage: alpha
- name: Cart.com
sourceDefinitionId: bb1a6d31-6879-4819-a2bd-3eed299ea8e2
dockerRepository: airbyte/source-cart
Expand Down
30 changes: 30 additions & 0 deletions airbyte-config/init/src/main/resources/seed/source_specs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1896,6 +1896,36 @@
supportsNormalization: false
supportsDBT: false
supported_destination_sync_modes: []
- dockerImage: "airbyte/source-callrail:0.1.0"
spec:
documentationUrl: "https://docs.airbyte.com/integrations/sources/callrail"
connectionSpecification:
$schema: "http://json-schema.org/draft-07/schema#"
title: "Call Rail Spec"
type: "object"
required:
- "api_key"
- "account_id"
- "start_date"
additionalProperties: true
properties:
api_key:
type: "string"
description: "API access key"
airbyte_secret: true
account_id:
type: "string"
description: "Account ID"
airbyte_secret: true
start_date:
type: "string"
description: "Start getting data from that date."
pattern: "^[0-9]{4}-[0-9]{2}-[0-9]{2}$"
examples:
- "%Y-%m-%d"
supportsNormalization: false
supportsDBT: false
supported_destination_sync_modes: []
- dockerImage: "airbyte/source-cart:0.2.0"
spec:
documentationUrl: "https://docs.airbyte.com/integrations/sources/cart"
Expand Down
6 changes: 6 additions & 0 deletions airbyte-integrations/connectors/source-callrail/.dockerignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
*
!Dockerfile
!main.py
!source_callrail
!setup.py
!secrets
38 changes: 38 additions & 0 deletions airbyte-integrations/connectors/source-callrail/Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
FROM python:3.9.11-alpine3.15 as base

# build and load all requirements
FROM base as builder
WORKDIR /airbyte/integration_code

# upgrade pip to the latest version
RUN apk --no-cache upgrade \
&& pip install --upgrade pip \
&& apk --no-cache add tzdata build-base


COPY setup.py ./
# install necessary packages to a temporary folder
RUN pip install --prefix=/install .

# build a clean environment
FROM base
WORKDIR /airbyte/integration_code

# copy all loaded and built libraries to a pure basic image
COPY --from=builder /install /usr/local
# add default timezone settings
COPY --from=builder /usr/share/zoneinfo/Etc/UTC /etc/localtime
RUN echo "Etc/UTC" > /etc/timezone

# bash is installed for more convenient debugging.
RUN apk --no-cache add bash

# copy payload code only
COPY main.py ./
COPY source_callrail ./source_callrail

ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.0
LABEL io.airbyte.name=airbyte/source-callrail
79 changes: 79 additions & 0 deletions airbyte-integrations/connectors/source-callrail/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
# Callrail Source

This is the repository for the Callrail configuration based source connector.
For information about how to use this connector within Airbyte, see [the documentation](https://docs.airbyte.io/integrations/sources/callrail).

## Local development

#### Building via Gradle
You can also build the connector in Gradle. This is typically used in CI and not needed for your development workflow.

To build using Gradle, from the Airbyte repository root, run:
```
./gradlew :airbyte-integrations:connectors:source-callrail:build
```

#### Create credentials
**If you are a community contributor**, follow the instructions in the [documentation](https://docs.airbyte.io/integrations/sources/callrail)
to generate the necessary credentials. Then create a file `secrets/config.json` conforming to the `source_callrail/spec.yaml` file.
Note that any directory named `secrets` is gitignored across the entire Airbyte repo, so there is no danger of accidentally checking in sensitive information.
See `integration_tests/sample_config.json` for a sample config file.

**If you are an Airbyte core member**, copy the credentials in Lastpass under the secret name `source callrail test creds`
and place them into `secrets/config.json`.

### Locally running the connector docker image

#### Build
First, make sure you build the latest Docker image:
```
docker build . -t airbyte/source-callrail:dev
```

You can also build the connector image via Gradle:
```
./gradlew :airbyte-integrations:connectors:source-callrail:airbyteDocker
```
When building via Gradle, the docker image name and tag, respectively, are the values of the `io.airbyte.name` and `io.airbyte.version` `LABEL`s in
the Dockerfile.

#### Run
Then run any of the connector commands as follows:
```
docker run --rm airbyte/source-callrail:dev spec
docker run --rm -v $(pwd)/secrets:/secrets airbyte/source-callrail:dev check --config /secrets/config.json
docker run --rm -v $(pwd)/secrets:/secrets airbyte/source-callrail:dev discover --config /secrets/config.json
docker run --rm -v $(pwd)/secrets:/secrets -v $(pwd)/integration_tests:/integration_tests airbyte/source-callrail:dev read --config /secrets/config.json --catalog /integration_tests/configured_catalog.json
```
## Testing

#### Acceptance Tests
Customize `acceptance-test-config.yml` file to configure tests. See [Source Acceptance Tests](https://docs.airbyte.io/connector-development/testing-connectors/source-acceptance-tests-reference) for more information.
If your connector requires to create or destroy resources for use during acceptance tests create fixtures for it and place them inside integration_tests/acceptance.py.

To run your integration tests with docker

### Using gradle to run tests
All commands should be run from airbyte project root.
To run unit tests:
```
./gradlew :airbyte-integrations:connectors:source-callrail:unitTest
```
To run acceptance and custom integration tests:
```
./gradlew :airbyte-integrations:connectors:source-callrail:integrationTest
```

## Dependency Management
All of your dependencies should go in `setup.py`, NOT `requirements.txt`. The requirements file is only used to connect internal Airbyte dependencies in the monorepo for local development.
We split dependencies between two groups, dependencies that are:
* required for your connector to work need to go to `MAIN_REQUIREMENTS` list.
* required for the testing need to go to `TEST_REQUIREMENTS` list

### Publishing a new version of the connector
You've checked out the repo, implemented a million dollar feature, and you're ready to share your changes with the world. Now what?
1. Make sure your changes are passing unit and integration tests.
1. Bump the connector version in `Dockerfile` -- just increment the value of the `LABEL io.airbyte.version` appropriately (we use [SemVer](https://semver.org/)).
1. Create a Pull Request.
1. Pat yourself on the back for being an awesome contributor.
1. Someone from Airbyte will take a look at your PR and iterate with you to merge it into master.
3 changes: 3 additions & 0 deletions airbyte-integrations/connectors/source-callrail/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#
# Copyright (c) 2022 Airbyte, Inc., all rights reserved.
#
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# See [Source Acceptance Tests](https://docs.airbyte.com/connector-development/testing-connectors/source-acceptance-tests-reference)
# for more information about how to configure these tests
connector_image: airbyte/source-callrail:dev
tests:
spec:
- spec_path: "source_callrail/spec.yaml"
timeout_seconds: 60
connection:
- config_path: "secrets/config.json"
status: "succeed"
- config_path: "integration_tests/invalid_config.json"
status: "failed"
discovery:
- config_path: "secrets/config.json"
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
empty_streams: ["calls", "conversations"]
full_refresh:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
#!/usr/bin/env sh

# Build latest connector image
docker build . -t $(cat acceptance-test-config.yml | grep "connector_image" | head -n 1 | cut -d: -f2-)

# Pull latest acctest image
docker pull airbyte/source-acceptance-test:latest

# Run
docker run --rm -it \
-v /var/run/docker.sock:/var/run/docker.sock \
-v /tmp:/tmp \
-v $(pwd):/test_input \
airbyte/source-acceptance-test \
--acceptance-test-config /test_input

9 changes: 9 additions & 0 deletions airbyte-integrations/connectors/source-callrail/build.gradle
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
plugins {
id 'airbyte-python'
id 'airbyte-docker'
id 'airbyte-source-acceptance-test'
}

airbytePython {
moduleDirectory 'source_callrail'
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#
# Copyright (c) 2022 Airbyte, Inc., all rights reserved.
#
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"calls": {
"start_time": "2999-10-30T00:00:00.000Z"
},
"conversations": {
"last_message_at": "2999-10-30T00:00:00.000Z"
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
#
# Copyright (c) 2022 Airbyte, Inc., all rights reserved.
#


import pytest

pytest_plugins = ("source_acceptance_test.plugin",)


@pytest.fixture(scope="session", autouse=True)
def connector_setup():
"""This fixture is a placeholder for external resources that acceptance test might require."""
# TODO: setup test dependencies if needed. otherwise remove the TODO comments
yield
# TODO: clean up test dependencies
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{
"streams": [
{
"stream": {
"name": "users",
"json_schema": {},
"supported_sync_modes": ["full_refresh", "incremental"]
},
"sync_mode": "full_refresh",
"destination_sync_mode": "append"
},
{
"stream": {
"name": "companies",
"json_schema": {},
"supported_sync_modes": ["full_refresh", "incremental"]
},
"sync_mode": "full_refresh",
"destination_sync_mode": "append"
}
]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"api_key": "",
"account_id": "",
"start_date": "2019-01-01"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"api_key": "XXXXXXXXXXXXXXXXXX",
"account_id": "XXXXXXXXXXXXXXXXXX",
"start_date": "2019-01-01"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"calls": {
"start_time": "2022-10-13T13:51:44.830-07:00"
},
"conversations": {
"last_message_at": "2022-10-13T13:51:44.830-07:00"
},
"users": {
"created_at": "2022-10-13T13:51:44.830-07:00"
},
"companies": {
"created_at": "2022-10-13T13:51:44.830-07:00"
}
}
13 changes: 13 additions & 0 deletions airbyte-integrations/connectors/source-callrail/main.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
#
# Copyright (c) 2022 Airbyte, Inc., all rights reserved.
#


import sys

from airbyte_cdk.entrypoint import launch
from source_callrail import SourceCallrail

if __name__ == "__main__":
source = SourceCallrail()
launch(source, sys.argv[1:])
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
-e ../../bases/source-acceptance-test
-e .
29 changes: 29 additions & 0 deletions airbyte-integrations/connectors/source-callrail/setup.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
#
# Copyright (c) 2022 Airbyte, Inc., all rights reserved.
#


from setuptools import find_packages, setup

MAIN_REQUIREMENTS = [
"airbyte-cdk~=0.1",
]

TEST_REQUIREMENTS = [
"pytest~=6.1",
"pytest-mock~=3.6.1",
"source-acceptance-test",
]

setup(
name="source_callrail",
description="Source implementation for Callrail.",
author="Airbyte",
author_email="contact@airbyte.io",
packages=find_packages(),
install_requires=MAIN_REQUIREMENTS,
package_data={"": ["*.json", "*.yaml", "schemas/*.json", "schemas/shared/*.json"]},
extras_require={
"tests": TEST_REQUIREMENTS,
},
)
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
#
# Copyright (c) 2022 Airbyte, Inc., all rights reserved.
#


from .source import SourceCallrail

__all__ = ["SourceCallrail"]
Loading

0 comments on commit a7ec584

Please sign in to comment.