Skip to content

Commit

Permalink
Fix typo in bigquery destination readme
Browse files Browse the repository at this point in the history
  • Loading branch information
sherifnada authored Sep 21, 2021
1 parent d1b37da commit c5450d7
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions airbyte-integrations/connectors/destination-bigquery/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#### Building via Gradle
From the Airbyte repository root, run:
```
./gradlew :airbyte-integrations:connectors:destination-dynamodb:build
./gradlew :airbyte-integrations:connectors:destination-bigquery:build
```

#### Create credentials
Expand All @@ -17,39 +17,39 @@ Note that the `secrets` directory is git-ignored by default, so there is no dang
#### Build
Build the connector image via Gradle:
```
./gradlew :airbyte-integrations:connectors:destination-dynamodb:airbyteDocker
./gradlew :airbyte-integrations:connectors:destination-bigquery:airbyteDocker
```
When building via Gradle, the docker image name and tag, respectively, are the values of the `io.airbyte.name` and `io.airbyte.version` `LABEL`s in
the Dockerfile.

#### Run
Then run any of the connector commands as follows:
```
docker run --rm airbyte/destination-dynamodb:dev spec
docker run --rm -v $(pwd)/secrets:/secrets airbyte/destination-dynamodb:dev check --config /secrets/config.json
docker run --rm -v $(pwd)/secrets:/secrets airbyte/destination-dynamodb:dev discover --config /secrets/config.json
docker run --rm -v $(pwd)/secrets:/secrets -v $(pwd)/integration_tests:/integration_tests airbyte/destination-dynamodb:dev read --config /secrets/config.json --catalog /integration_tests/configured_catalog.json
docker run --rm airbyte/destination-bigquery:dev spec
docker run --rm -v $(pwd)/secrets:/secrets airbyte/destination-bigquery:dev check --config /secrets/config.json
docker run --rm -v $(pwd)/secrets:/secrets airbyte/destination-bigquery:dev discover --config /secrets/config.json
docker run --rm -v $(pwd)/secrets:/secrets -v $(pwd)/integration_tests:/integration_tests airbyte/destination-bigquery:dev read --config /secrets/config.json --catalog /integration_tests/configured_catalog.json
```

## Testing
We use `JUnit` for Java tests.

### Unit and Integration Tests
Place unit tests under `src/test/io/airbyte/integrations/destinations/dynamodb`.
Place unit tests under `src/test/io/airbyte/integrations/destinations/bigquery`.

#### Acceptance Tests
Airbyte has a standard test suite that all destination connectors must pass. Implement the `TODO`s in
`src/test-integration/java/io/airbyte/integrations/destinations/dynamodbDestinationAcceptanceTest.java`.
`src/test-integration/java/io/airbyte/integrations/destinations/BigQueryDestinationAcceptanceTest.java`.

### Using gradle to run tests
All commands should be run from airbyte project root.
To run unit tests:
```
./gradlew :airbyte-integrations:connectors:destination-dynamodb:unitTest
./gradlew :airbyte-integrations:connectors:destination-bigquery:unitTest
```
To run acceptance and custom integration tests:
```
./gradlew :airbyte-integrations:connectors:destination-dynamodb:integrationTest
./gradlew :airbyte-integrations:connectors:destination-bigquery:integrationTest
```

## Dependency Management
Expand Down

0 comments on commit c5450d7

Please sign in to comment.