fix exception test, copy changes

airbytehq · Jul 21, 2021 · c6fe7ae · c6fe7ae
1 parent e8b9fd2
commit c6fe7ae
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/.../io/airbyte/integrations/destination/buffered_stream_consumer/BufferedStreamConsumer.java b/.../io/airbyte/integrations/destination/buffered_stream_consumer/BufferedStreamConsumer.java
@@ -68,14 +68,14 @@
  * </p>
  *
  * <p>
- * Throughout the lifecycle of the consumer, records get promoted from buffered to flushed to
- * committed. A record when it is received is immediately buffered. When the buffer fills up, all
- * buffered records are flushed out of memory using the user-provided recordWriter. When this flush
- * happens, a state message is moved from pending to flushed. On close, if the user-provided onClose
- * function is successful, then the flushed state record is considered committed and is then
- * emitted. We expect this class to only ever emit either 1 state message (in the case of a full or
- * partial success) or 0 state messages (in the case where the onClose step was never reached or did
- * not complete without exception).
+ * Throughout the lifecycle of the consumer, messages get promoted from buffered to flushed to
+ * committed. A record message when it is received is immediately buffered. When the buffer fills
+ * up, all buffered records are flushed out of memory using the user-provided recordWriter. When
+ * this flush happens, a state message is moved from pending to flushed. On close, if the
+ * user-provided onClose function is successful, then the flushed state record is considered
+ * committed and is then emitted. We expect this class to only ever emit either 1 state message (in
+ * the case of a full or partial success) or 0 state messages (in the case where the onClose step
+ * was never reached or did not complete without exception).
  * </p>
  *
  * <p>

diff --git a/...airbyte/integrations/destination/buffered_stream_consumer/BufferedStreamConsumerTest.java b/...airbyte/integrations/destination/buffered_stream_consumer/BufferedStreamConsumerTest.java
@@ -258,7 +258,7 @@ void testExceptionDuringOnClose() throws Exception {
     consumeRecords(consumer, expectedRecordsBatch1);
     consumer.accept(STATE_MESSAGE1);
     consumeRecords(consumer, expectedRecordsBatch2);
-    consumer.close();
+    assertThrows(IllegalStateException.class, () -> consumer.close());
 
     verifyStartAndClose();