Skip to content

Commit

Permalink
Change bases to resources
Browse files Browse the repository at this point in the history
  • Loading branch information
terencecho committed Jul 4, 2022
1 parent efc27a3 commit c94b03d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions tools/ci_credentials/ci_credentials/secrets_loader.py
Original file line number Diff line number Diff line change
Expand Up @@ -223,12 +223,12 @@ def read_from_gsm(self) -> int:
return {k: v[1] for k, v in secrets.items()}

def write_to_storage(self, secrets: Mapping[Tuple[str, str], str]) -> int:
"""Tries to save target secrets to the airbyte-integrations/connectors|bases/{connector_name}/secrets folder"""
"""Tries to save target secrets to the airbyte-integrations/connectors|resources/{connector_name}/secrets folder"""
if not secrets:
return 0
for (connector_name, filename), secret_value in secrets.items():
if connector_name == "base-normalization":
secrets_dir = f"airbyte-integrations/bases/{connector_name}/secrets"
secrets_dir = f"airbyte-integrations/resources/{connector_name}/secrets"
else:
secrets_dir = f"airbyte-integrations/connectors/{connector_name}/secrets"

Expand Down
4 changes: 2 additions & 2 deletions tools/ci_credentials/tests/test_secrets.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,8 @@ def test_read(connector_name, gsm_secrets, expected_secrets):
"airbyte-integrations/connectors/source-test2/secrets/auth.json"]),
("base-normalization", {"test.json": "test_value", "auth.json": "test_auth"},
["airbyte-integrations/bases/base-normalization/secrets/test.json",
"airbyte-integrations/bases/base-normalization/secrets/auth.json"]),
["airbyte-integrations/resources/base-normalization/secrets/test.json",
"airbyte-integrations/resources/base-normalization/secrets/auth.json"]),
),
ids=["single", "multi", "base-normalization"],
)
Expand Down

0 comments on commit c94b03d

Please sign in to comment.