Skip to content

Commit

Permalink
🪟 🎨 Front end/Design tweaks (#14257)
Browse files Browse the repository at this point in the history
* updates from pairing

* cleanup from review
  • Loading branch information
teallarson authored Jul 8, 2022
1 parent 1cf89c6 commit cd1d960
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 9 deletions.
7 changes: 3 additions & 4 deletions airbyte-webapp/src/components/ConnectorIcon/ConnectorIcon.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,14 @@ interface Props {
small?: boolean;
}

export const Content = styled.div<{ $small?: boolean }>`
export const Content = styled.div`
height: 25px;
width: 25px;
border-radius: ${({ $small }) => ($small ? 0 : 50)}%;
overflow: hidden;
`;

export const ConnectorIcon: React.FC<Props> = ({ icon, className, small }) => (
<Content className={className} $small={small} aria-hidden="true">
export const ConnectorIcon: React.FC<Props> = ({ icon, className }) => (
<Content className={className} aria-hidden="true">
{getIcon(icon)}
</Content>
);
2 changes: 1 addition & 1 deletion airbyte-webapp/src/components/ContentCard/ContentCard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ interface IProps {
const Title = styled(H5)<{ light?: boolean }>`
padding: ${({ light }) => (light ? "19px 20px 20px" : "25px 25px 22px")};
color: ${({ theme }) => theme.darkPrimaryColor};
box-shadow: ${({ light, theme }) => (light ? "none" : `0 1px 2px ${theme.shadowColor}`)};
border-bottom: ${({ light }) => (light ? "none" : "#e8e8ed 1px solid")};
font-weight: 600;
letter-spacing: 0.008em;
border-radius: 10px 10px 0 0;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const Image = styled(ConnectorIcon)`
const ConnectorCell: React.FC<IProps> = ({ value, enabled, img }) => {
return (
<Content enabled={enabled}>
<Image small icon={img} />
<Image icon={img} />
{value}
</Content>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ const NameCell: React.FC<Props> = ({ value, enabled, status, icon, img }) => {
return (
<Content>
{status ? <StatusIcon title={title} status={statusIconStatus} /> : <Space />}
{icon && <Image small icon={img} />}
{icon && <Image icon={img} />}
<Name enabled={enabled}>{value}</Name>
</Content>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@ const ConnectionCell: React.FC<ConnectionCellProps> = ({
return (
<>
<Connector>
<Icon small icon={sourceIcon} />
<Icon icon={sourceIcon} />
{sourceDefinitionName}
</Connector>
<Connector>
<Arrow icon={faArrowRight} />
<Icon small icon={destinationIcon} />
<Icon icon={destinationIcon} />
{destinationDefinitionName}
</Connector>
</>
Expand Down

0 comments on commit cd1d960

Please sign in to comment.