🎉 Source Bing Ads: add Redirect URI & Tenant ID to spec (#11311)

airbytehq · Mar 31, 2022 · d15c83d · d15c83d
1 parent 78cafc5
commit d15c83d
Show file tree

Hide file tree

Showing 6 changed files with 25 additions and 3 deletions.
diff --git a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml
@@ -91,7 +91,7 @@
 - name: Bing Ads
   sourceDefinitionId: 47f25999-dd5e-4636-8c39-e7cea2453331
   dockerRepository: airbyte/source-bing-ads
-  dockerImageTag: 0.1.3
+  dockerImageTag: 0.1.4
   documentationUrl: https://docs.airbyte.io/integrations/sources/bing-ads
   icon: bingads.svg
   sourceType: api

diff --git a/airbyte-integrations/connectors/source-bing-ads/Dockerfile b/airbyte-integrations/connectors/source-bing-ads/Dockerfile
@@ -12,5 +12,5 @@ RUN pip install .
 ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
 ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
 
-LABEL io.airbyte.version=0.1.3
+LABEL io.airbyte.version=0.1.4
 LABEL io.airbyte.name=airbyte/source-bing-ads
diff --git a/airbyte-integrations/connectors/source-bing-ads/integration_tests/invalid_config.json b/airbyte-integrations/connectors/source-bing-ads/integration_tests/invalid_config.json
@@ -6,6 +6,8 @@
   "refresh_token": "as2Ggas23gsa236gasgaskjfhas7i8ygf78as7osa7gy87asg8as7tg6as",
   "client_secret": "1234",
   "client_id": "123",
+  "tenant_id": "common",
+  "redirect_uri": "",
   "reports_start_date": "2018-11-13",
   "hourly_reports": true,
   "daily_reports": false,

diff --git a/airbyte-integrations/connectors/source-bing-ads/source_bing_ads/client.py b/airbyte-integrations/connectors/source-bing-ads/source_bing_ads/client.py
@@ -40,6 +40,8 @@ def __init__(
         customer_id: str,
         client_secret: str,
         client_id: str,
+        tenant_id: str,
+        redirect_uri: str,
         refresh_token: str,
         reports_start_date: str,
         hourly_reports: bool,
@@ -52,7 +54,8 @@ def __init__(
         self.authentication = OAuthWebAuthCodeGrant(
             client_id,
             client_secret,
-            "",
+            redirect_uri,
+            tenant=tenant_id,
         )
 
         self.refresh_token = refresh_token

diff --git a/airbyte-integrations/connectors/source-bing-ads/source_bing_ads/spec.json b/airbyte-integrations/connectors/source-bing-ads/source_bing_ads/spec.json
@@ -86,6 +86,20 @@
         "description": "Developer token associated with user.",
         "airbyte_secret": true
       },
+      "tenant_id": {
+        "type": "string",
+        "title": "Tenant ID",
+        "description": "The Tenant ID of your Microsoft Advertising developer application.",
+        "airbyte_secret": true,
+        "default": "common"
+      },
+      "redirect_uri": {
+        "type": "string",
+        "title": "Redirect URI",
+        "description": "The Redirect URI of your Microsoft Advertising developer application.",
+        "airbyte_secret": true,
+        "default": ""
+      },
       "refresh_token": {
         "type": "string",
         "title": "Refresh Token",

diff --git a/docs/integrations/sources/bing-ads.md b/docs/integrations/sources/bing-ads.md
@@ -56,6 +56,8 @@ API limits number of requests for all Microsoft Advertising clients. You can fin
 * refresh\_token: Token received during [auth process](https://docs.microsoft.com/en-us/advertising/guides/authentication-oauth?view=bingads-13)
 * client\_secret: Secret generated during application registration
 * client\_id: Id generated during application registration
+* tenant_id: Tenant generated during application registration
+* redirect\_uri: You can create Redirect URI from azure application configuration. e.g: https://login.microsoftonline.com/{tenant_id}/oauth2/nativeclient
 * reports\_start\_date: From which date report generation should start
 * report\_aggregation: Defines how report data will be aggregated
 * hourly\_reports: includes hourly report streams if true
@@ -77,6 +79,7 @@ Be aware that `refresh token` will expire in 90 days. You need to repeat auth pr
 
 | Version | Date | Pull Request | Subject |
 | :--- | :--- | :--- | :--- |
+| 0.1.4 | 2022-03-22 | [9510](https://github.com/airbytehq/airbyte/pull/9510) | Added optional Redirect URI & Tenant ID to spec |
 | 0.1.3 | 2022-01-14 | [9510](https://github.com/airbytehq/airbyte/pull/9510) | Fixed broken dependency that blocked connector's operations |
 | 0.1.2 | 2021-12-14 | [8429](https://github.com/airbytehq/airbyte/pull/8429) | Update titles and descriptions |
 | 0.1.1 | 2021-08-31 | [5750](https://github.com/airbytehq/airbyte/pull/5750) | Added reporting streams\) |