-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
🪟🔧Update Segment tracking event names (#13859)
* wip * Update high priority segment calls * other segment calls use new format * allow for non-legacy segment calls * comment * cleanup * use single TrackActionAction * renames from code review * typo fix * WIP connect hook to react hooks testing library * test parsing of legacy namespace * cleanup
- Loading branch information
1 parent
111ccce
commit df24831
Showing
14 changed files
with
182 additions
and
75 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
import { renderHook } from "@testing-library/react-hooks"; | ||
|
||
import { useAnalyticsService } from "./services/Analytics/useAnalyticsService"; | ||
import { TrackActionLegacyType, TrackActionNamespace, TrackActionType, useTrackAction } from "./useTrackAction"; | ||
|
||
jest.mock("./services/Analytics/useAnalyticsService", () => { | ||
const mockTrack = jest.fn(); | ||
return { useAnalyticsService: () => ({ track: mockTrack }) }; | ||
}); | ||
|
||
describe("With legacy namespace", () => { | ||
test("it parses namespace and legacy name when calling the hook", () => { | ||
const mockUseTrackAction = renderHook(() => | ||
useTrackAction(TrackActionNamespace.SOURCE, TrackActionLegacyType.NEW_SOURCE) | ||
); | ||
mockUseTrackAction.result.current("test action sent", TrackActionType.CREATE, {}); | ||
const analyticsService = useAnalyticsService(); | ||
|
||
expect(analyticsService.track).toHaveBeenCalledWith( | ||
"Airbyte.UI.Source.Create", | ||
expect.objectContaining({ legacy_event_name: "New Source - Action" }) | ||
); | ||
}); | ||
}); | ||
|
||
describe("Without legacy namespace", () => { | ||
test("legacy namespace is passed as empty string if none is received", () => { | ||
const mockUseTrackAction = renderHook(() => useTrackAction(TrackActionNamespace.CONNECTION)); | ||
mockUseTrackAction.result.current("another test action", TrackActionType.CREATE, {}); | ||
const analyticsService = useAnalyticsService(); | ||
expect(analyticsService.track).toHaveBeenCalledWith( | ||
"Airbyte.UI.Connection.Create", | ||
expect.objectContaining({ legacy_event_name: "" }) | ||
); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.