Add testing on deduplication of catalogs

airbytehq · Mar 3, 2022 · e9052f2 · e9052f2
1 parent f5fc58f
commit e9052f2
Showing 1 changed file with 22 additions and 2 deletions.
diff --git a/...istence/src/test/java/io/airbyte/config/persistence/ConfigRepositoryE2EReadWriteTest.java b/...istence/src/test/java/io/airbyte/config/persistence/ConfigRepositoryE2EReadWriteTest.java
@@ -4,6 +4,7 @@
 
 package io.airbyte.config.persistence;
 
+import static io.airbyte.db.instance.configs.jooq.Tables.ACTOR_CATALOG;
 import static org.junit.jupiter.api.Assertions.*;
 import static org.mockito.Mockito.spy;
 
@@ -24,9 +25,13 @@
 import io.airbyte.db.instance.development.DevDatabaseMigrator;
 import io.airbyte.db.instance.development.MigrationDevHelper;
 import io.airbyte.protocol.models.AirbyteCatalog;
+import io.airbyte.protocol.models.CatalogHelpers;
 import io.airbyte.protocol.models.ConnectorSpecification;
+import io.airbyte.protocol.models.Field;
+import io.airbyte.protocol.models.JsonSchemaType;
 import io.airbyte.validation.json.JsonValidationException;
 import java.io.IOException;
+import java.sql.SQLException;
 import java.util.Optional;
 import java.util.UUID;
 import org.junit.jupiter.api.AfterAll;
@@ -101,7 +106,7 @@ void testWorkspaceCountConnections() throws IOException {
   }
 
   @Test
-  void testSimpleInsertActorCatalog() throws IOException, JsonValidationException {
+  void testSimpleInsertActorCatalog() throws IOException, JsonValidationException, SQLException {
 
     final StandardWorkspace workspace = MockData.standardWorkspace();
 
@@ -123,7 +128,7 @@ void testSimpleInsertActorCatalog() throws IOException, JsonValidationException
         .withConnectionSpecification(Jsons.deserialize("{}"));
     configRepository.writeSourceConnection(source, specification);
 
-    final AirbyteCatalog actorCatalog = new AirbyteCatalog();
+    final AirbyteCatalog actorCatalog = CatalogHelpers.createAirbyteCatalog("clothes", Field.of("name", JsonSchemaType.STRING));
     configRepository.writeActorCatalogFetchEvent(
         actorCatalog, source.getSourceId(), "1.2.0", "ConfigHash");
 
@@ -133,6 +138,21 @@ void testSimpleInsertActorCatalog() throws IOException, JsonValidationException
     assertEquals(actorCatalog, catalog.get());
     assertFalse(configRepository.getSourceCatalog(source.getSourceId(), "1.3.0", "ConfigHash").isPresent());
     assertFalse(configRepository.getSourceCatalog(source.getSourceId(), "1.2.0", "OtherConfigHash").isPresent());
+
+    configRepository.writeActorCatalogFetchEvent(actorCatalog, source.getSourceId(), "1.3.0", "ConfigHash");
+    final Optional<AirbyteCatalog> catalogNewConnectorVersion =
+        configRepository.getActorCatalog(source.getSourceId(), "1.3.0", "ConfigHash");
+    assertTrue(catalogNewConnectorVersion.isPresent());
+    assertEquals(actorCatalog, catalogNewConnectorVersion.get());
+
+    configRepository.writeActorCatalogFetchEvent(actorCatalog, source.getSourceId(), "1.2.0", "OtherConfigHash");
+    final Optional<AirbyteCatalog> catalogNewConfig =
+        configRepository.getActorCatalog(source.getSourceId(), "1.2.0", "OtherConfigHash");
+    assertTrue(catalogNewConfig.isPresent());
+    assertEquals(actorCatalog, catalogNewConfig.get());
+
+    final int catalogDbEntry = database.query(ctx -> ctx.selectCount().from(ACTOR_CATALOG)).fetchOne().into(int.class);
+    assertEquals(1, catalogDbEntry);
   }
 
 }