fix type number in schema (#20068)

airbytehq · Dec 6, 2022 · f1c9d8d · f1c9d8d
1 parent 2b045a9
commit f1c9d8d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/airbyte-webapp/src/core/jsonSchema/schemaToYup.test.ts b/airbyte-webapp/src/core/jsonSchema/schemaToYup.test.ts
@@ -73,6 +73,9 @@ it("should build schema for conditional case", () => {
         start_date: {
           type: "string",
         },
+        max_objects: {
+          type: "number",
+        },
         credentials: {
           type: "object",
           oneOf: [
@@ -104,6 +107,7 @@ it("should build schema for conditional case", () => {
 
   const expectedSchema = yup.object().shape({
     start_date: yup.string().trim().required("form.empty.error").transform(String),
+    max_objects: yup.number().transform((x) => x),
     credentials: yup.object().shape({
       api_key: yup.string().trim().required("form.empty.error").transform(String),
     }),

diff --git a/airbyte-webapp/src/core/jsonSchema/schemaToYup.ts b/airbyte-webapp/src/core/jsonSchema/schemaToYup.ts
@@ -68,6 +68,7 @@ export const buildYupFormForJsonSchema = (
       schema = yup.boolean();
       break;
     case "integer":
+    case "number":
       schema = yup.number().transform((value) => (isNaN(value) ? undefined : value));
 
       if (jsonSchema?.minimum !== undefined) {