Skip to content

Commit

Permalink
Remove unnecessary test logging. (#15384)
Browse files Browse the repository at this point in the history
This logging makes it tough to figure out what is happening in the tests.
  • Loading branch information
davinchia authored Aug 6, 2022
1 parent 5242ff8 commit f9026b0
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion tools/bin/acceptance_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ VERSION=dev TRACKING_STRATEGY=logging USE_STREAM_CAPABLE_STATE=true docker-compo

# Sometimes source/dest containers using airbyte volumes survive shutdown, which need to be killed in order to shut down properly.
shutdown_cmd="docker-compose down -v || docker kill \$(docker ps -a -f volume=airbyte_workspace -f volume=airbyte_data -f volume=airbyte_db -q) && docker-compose down -v"
trap "echo 'docker-compose logs:' && docker-compose logs -t --tail 1000 && $shutdown_cmd" EXIT
# Uncomment for debugging. Warning, this is verbose.
#trap "echo 'docker-compose logs:' && docker-compose logs -t --tail 1000 && $shutdown_cmd" EXIT

echo "Waiting for services to begin"
while [[ "$(curl -s -o /dev/null -w ''%{http_code}'' localhost:8000/api/v1/health)" != "200" ]]; do echo "Waiting for docker deployment.."; sleep 5; done
Expand Down
3 changes: 2 additions & 1 deletion tools/bin/acceptance_test_kube.sh
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ if [ -n "$CI" ]; then
describe_nodes;
describe_pods;
}
trap "mkdir -p /tmp/kubernetes_logs && write_all_logs" EXIT
# Uncomment for debugging. Warning, this is verbose.
# trap "mkdir -p /tmp/kubernetes_logs && write_all_logs" EXIT
fi

kubectl port-forward svc/airbyte-server-svc 8001:8001 &
Expand Down

0 comments on commit f9026b0

Please sign in to comment.