🐛Source Freshdesk: Fix schema types (#20416)

* Fix schema types * Updated version * Updated acceptance tests * auto-bump connector version Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
airbytehq · Jan 6, 2023 · fc05f65 · fc05f65
1 parent 4e4800b
commit fc05f65
Show file tree

Hide file tree

Showing 8 changed files with 166 additions and 123 deletions.
diff --git a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml
@@ -516,7 +516,7 @@
 - name: Freshdesk
   sourceDefinitionId: ec4b9503-13cb-48ab-a4ab-6ade4be46567
   dockerRepository: airbyte/source-freshdesk
-  dockerImageTag: 1.0.0
+  dockerImageTag: 2.0.0
   documentationUrl: https://docs.airbyte.com/integrations/sources/freshdesk
   icon: freshdesk.svg
   sourceType: api

diff --git a/airbyte-config/init/src/main/resources/seed/source_specs.yaml b/airbyte-config/init/src/main/resources/seed/source_specs.yaml
@@ -4386,7 +4386,7 @@
     supportsNormalization: false
     supportsDBT: false
     supported_destination_sync_modes: []
-- dockerImage: "airbyte/source-freshdesk:1.0.0"
+- dockerImage: "airbyte/source-freshdesk:2.0.0"
   spec:
     documentationUrl: "https://docs.airbyte.com/integrations/sources/freshdesk"
     connectionSpecification:

diff --git a/airbyte-integrations/connectors/source-freshdesk/Dockerfile b/airbyte-integrations/connectors/source-freshdesk/Dockerfile
@@ -34,5 +34,5 @@ COPY source_freshdesk ./source_freshdesk
 ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
 ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
 
-LABEL io.airbyte.version=1.0.0
+LABEL io.airbyte.version=2.0.0
 LABEL io.airbyte.name=airbyte/source-freshdesk
diff --git a/airbyte-integrations/connectors/source-freshdesk/acceptance-test-config.yml b/airbyte-integrations/connectors/source-freshdesk/acceptance-test-config.yml
@@ -17,13 +17,21 @@ acceptance_tests:
       - config_path: "secrets/config.json"
         # please remove the backward_capability checks bypass, once updated to the newer version
         backward_compatibility_tests_config:
-          disable_for_version: "0.3.8"
+          disable_for_version: "1.0.0"
   basic_read:
     tests:
       - config_path: "secrets/config.json"
         expect_records:
           path: "integration_tests/expected_records.jsonl"
+          extra_fields: no
+          exact_order: no
+          extra_records: yes
         timeout_seconds: 600
+        empty_streams:
+          - name: skills
+            bypass_reason: "no records"
+          - name: products
+            bypass_reason: "no records"
   incremental:
     tests:
       - config_path: "secrets/config.json"

diff --git a/airbyte-integrations/connectors/source-freshdesk/integration_tests/expected_records.jsonl b/airbyte-integrations/connectors/source-freshdesk/integration_tests/expected_records.jsonl
diff --git a/airbyte-integrations/connectors/source-freshdesk/setup.py b/airbyte-integrations/connectors/source-freshdesk/setup.py
@@ -6,7 +6,7 @@
 from setuptools import find_packages, setup
 
 MAIN_REQUIREMENTS = [
-    "airbyte-cdk~=0.2",
+    "airbyte-cdk",
     "backoff==1.10.0",
     "requests==2.25.1",
     "pendulum==2.1.2",

diff --git a/airbyte-integrations/connectors/source-freshdesk/source_freshdesk/schemas/sla_policies.json b/airbyte-integrations/connectors/source-freshdesk/source_freshdesk/schemas/sla_policies.json
@@ -138,7 +138,10 @@
               "type": ["null", "integer"]
             },
             "agent_ids": {
-              "type": ["null", "integer"]
+              "type": ["null", "array"],
+              "items": {
+                "type": ["null", "integer"]
+              }
             }
           }
         },
@@ -152,7 +155,10 @@
                   "type": ["null", "integer"]
                 },
                 "agent_ids": {
-                  "type": ["null", "integer"]
+                  "type": ["null", "array"],
+                  "items": {
+                    "type": ["null", "integer"]
+                  }
                 }
               }
             },
@@ -163,7 +169,10 @@
                   "type": ["null", "integer"]
                 },
                 "agent_ids": {
-                  "type": ["null", "integer"]
+                  "type": ["null", "array"],
+                  "items": {
+                    "type": ["null", "integer"]
+                  }
                 }
               }
             },
@@ -174,7 +183,10 @@
                   "type": ["null", "integer"]
                 },
                 "agent_ids": {
-                  "type": ["null", "integer"]
+                  "type": ["null", "array"],
+                  "items": {
+                    "type": ["null", "integer"]
+                  }
                 }
               }
             },
@@ -185,7 +197,10 @@
                   "type": ["null", "integer"]
                 },
                 "agent_ids": {
-                  "type": ["null", "integer"]
+                  "type": ["null", "array"],
+                  "items": {
+                    "type": ["null", "integer"]
+                  }
                 }
               }
             }

diff --git a/docs/integrations/sources/freshdesk.md b/docs/integrations/sources/freshdesk.md
@@ -67,6 +67,7 @@ The Freshdesk connector should not run into Freshdesk API limitations under norm
 
 | Version | Date       | Pull Request                                             | Subject                                                                               |
 |:--------|:-----------|:---------------------------------------------------------|:--------------------------------------------------------------------------------------|
+| 2.0.0   | 2022-12-20 | [20416](https://github.com/airbytehq/airbyte/pull/20416) | Fix `SlaPolicies` stream schema                                                       |
 | 1.0.0   | 2022-11-16 | [19496](https://github.com/airbytehq/airbyte/pull/19496) | Fix `Contacts` stream schema                                                          |
 | 0.3.8   | 2022-11-11 | [19349](https://github.com/airbytehq/airbyte/pull/19349) | Do not rely on response.json() when deciding to retry a request                       |
 | 0.3.7   | 2022-11-03 | [18397](https://github.com/airbytehq/airbyte/pull/18397) | Fix base url for v2 API.                                                              |