New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link logic in documentation panel #11313

Closed

timroes opened this issue Mar 22, 2022 · 1 comment · Fixed by #11400

Assignees

Labels

area/frontend type/bug

Collaborator

timroes commented Mar 22, 2022

The way links are currently handled in the documentation sidepanel for connectors is having several issues.

It's not properly working for fragment-only URLs (quick fix preventing an app crash in Fix breaking the app with fragment links in docs #11312)
Absolute URLs are turned into relative URLs within the airbyte application.
Potential other edge cases not handled.

Problematic code: https://github.com/airbytehq/airbyte/blob/master/airbyte-webapp/src/views/Connector/ServiceForm/components/Controls/Instruction.tsx#L74-L79

timroes added type/bug area/frontend labels

Collaborator

octavia-squidington-iii commented Mar 22, 2022

cc @airbytehq/frontend

timroes mentioned this issue

Fix breaking the app with fragment links in docs #11312

Merged

timroes self-assigned this

timroes mentioned this issue

Fix links in documentation sideview #11400

Merged

timroes closed this as completed in #11400

timroes added the area/frontend label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment