Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links in documentation sideview #11400

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Conversation

timroes
Copy link
Collaborator

@timroes timroes commented Mar 24, 2022

What

Fixes #11313

This fixes all form of broken links in the documentation sideview:

  • External Links will work properly again
  • "Internal" links (i.e. links to another page in our own documentation) will now bring you properly to our documentation page
  • Fragment only links (i.e. pointing to another part within the same documentation) will now cause the sideview to scroll properly to that part

In addition I modified the create react app development server to serve our documentation files the same way we bundle them in Docker, so documentation will now also work properly when using npm start.

@timroes timroes requested a review from a team as a code owner March 24, 2022 15:50
@timroes timroes requested a review from jamakase March 24, 2022 15:50
@github-actions github-actions bot added the area/platform issues related to the platform label Mar 24, 2022
Copy link
Contributor

@jamakase jamakase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Haven't tested locally.

@timroes timroes merged commit 2e55e4c into master Mar 25, 2022
@timroes timroes deleted the tim/fix-documentation-links branch March 25, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix link logic in documentation panel
2 participants