Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Google Ads Sync option to skip inactive accounts rather than failing sync for all accounts #12486

Closed
Tracked by #11758
robby-rob opened this issue Apr 29, 2022 · 3 comments · Fixed by #12914
Closed
Tracked by #11758

Comments

@robby-rob
Copy link

robby-rob commented Apr 29, 2022

Tell us about the problem you're trying to solve

When using the Customer ID(s) feature in Google Ads source, an account may go inactive if it has not been used after some time. This causes the sync to fail for all accounts until the inactive account id is removed from the source configuration.

Describe the solution you’d like

Preferred solutions, as notifications about an account expiration happen from Google already:

  • Raise a warning instead of an error when the error_code from Google is "authorization_error: CUSTOMER_NOT_ENABLED" is thrown, skipping the inactive account.
  • Have an option in the configuration to skip inactive accounts (they may become active again later)

More involved solution:

  • Have an option to pull from all active accounts, rather than a manual entry of individual accounts
  • Similar to selecting the streams in the connection, have the ability to select from accounts and possibly see the status

Another thought:

  • Scan all accounts in the Source setup for being active. If the Airbyte API allows at a later time to test connection then this can be checked before any syncs are started via an orchestrator using the API.

Describe the alternative you’ve considered or used

  • Remove inactive accounts manually when an error occurs
  • Create a source for each individual account

Additional context

Section from the error log:

google.ads.googleads.errors.GoogleAdsException: (<_InactiveRpcError of RPC that terminated with:
	status = StatusCode.PERMISSION_DENIED
	details = "The caller does not have permission"
	debug_error_string = "{"created":"@1651243103.611933974","description":"Error received from peer ipv4:000.000.000.000:443","file":"src/core/lib/surface/call.cc","file_line":903,"grpc_message":"The caller does not have permission","grpc_status":7}"
>, <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.PERMISSION_DENIED
	details = "The caller does not have permission"
	debug_error_string = "{"created":"@1651243103.611933974","description":"Error received from peer ipv4:000.000.000.000:443","file":"src/core/lib/surface/call.cc","file_line":903,"grpc_message":"The caller does not have permission","grpc_status":7}"
>, errors {
  error_code {
    authorization_error: CUSTOMER_NOT_ENABLED
  }
  message: "The customer can\'t be used because it isn\'t enabled."
}

Are you willing to submit a PR?

Not at this time

@robby-rob robby-rob added needs-triage type/enhancement New feature or request labels Apr 29, 2022
@robby-rob robby-rob changed the title Source Google Ads Sync fails with inactive Source Google Ads Sync fails with inactive accounts Apr 29, 2022
@robby-rob robby-rob changed the title Source Google Ads Sync fails with inactive accounts Source Google Ads Sync fails for all accounts when one becomes inactive Apr 29, 2022
@robby-rob robby-rob changed the title Source Google Ads Sync fails for all accounts when one becomes inactive Source Google Ads Sync option to skip inactive accounts rather than failing sync for all accounts Apr 30, 2022
@bleonard bleonard added autoteam team/tse Technical Support Engineers labels May 1, 2022
@davydov-d
Copy link
Collaborator

@sherifnada this looks like a bug to me, should I include it into the certification scope?

@davydov-d
Copy link
Collaborator

@sherifnada this looks like a bug to me, should I include it into the certification scope?

@misteryeo could you please comment on that?

@misteryeo
Copy link
Contributor

Agreed, let's add this to verification scope for GA and add it to that epic please @davydov-d!

@misteryeo misteryeo added team/connectors-python connectors/sources-api and removed type/enhancement New feature or request needs-triage team/tse Technical Support Engineers labels May 11, 2022
@davydov-d davydov-d self-assigned this May 12, 2022
@davydov-d davydov-d linked a pull request May 18, 2022 that will close this issue
davydov-d added a commit that referenced this issue May 25, 2022
* #12486 and #49 from alpha-beta-issues fixes

* test updates for #airbyte/12486 and #alpha-beta-issues/49

* #12486 #49-alpha-beta-issues PR comment fixes

* #12486 doc upd: add note on use of custom queries

* auto-bump connector version

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
jscottpolevault pushed a commit to jscottpolevault/airbyte that referenced this issue Jun 1, 2022
…ehq#12914)

* airbytehq#12486 and airbytehq#49 from alpha-beta-issues fixes

* test updates for #airbyte/12486 and #alpha-beta-issues/49

* airbytehq#12486 airbytehq#49-alpha-beta-issues PR comment fixes

* airbytehq#12486 doc upd: add note on use of custom queries

* auto-bump connector version

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants