Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Google Ads: build fails on integration tests #13145

Closed
davydov-d opened this issue May 24, 2022 · 0 comments · Fixed by #13149
Closed

Source Google Ads: build fails on integration tests #13145

davydov-d opened this issue May 24, 2022 · 0 comments · Fixed by #13149
Assignees
@davydov-d
Labels
connectors/source/google-ads team/connectors-python type/bug Something isn't working

Comments

@davydov-d
Copy link
Collaborator

davydov-d commented May 24, 2022 •
edited
Loading

Reproduced from time to time
https://github.com/airbytehq/airbyte/actions/runs/2362841778

Reason: improperly constructed integration_tests/configured_catalog.json file. Primary keys of the configured streams are not set in the config what leads to incorrect comparison of emitted records within the test (by record hash when it should be by primary key).
@davydov-d davydov-d self-assigned this May 24, 2022
davydov-d added a commit that referenced this issue May 24, 2022
@davydov-d
#13145 fix configured catalog of source Googgle Ads
96e72a4
@davydov-d davydov-d linked a pull request May 24, 2022 that will close this issue
Source Google Ads: fix configured catalog #13149
Merged
davydov-d added a commit that referenced this issue May 25, 2022
@davydov-d
#13145 fix configured catalog of source Googgle Ads (#13149)
5a4cb12
Merged
jscottpolevault pushed a commit to jscottpolevault/airbyte that referenced this issue Jun 1, 2022
@davydov-d
airbytehq#13145 fix configured catalog of source Googgle Ads (airbyte…
d832e6b 
…hq#13149)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davydov-d davydov-d

Labels
connectors/source/google-ads team/connectors-python type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Source Google Ads: fix configured catalog airbytehq/airbyte
2 participants
@davydov-d @octavia-squidington-iii