Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH control host port setting not used when tunneling #13758

Closed
wesen opened this issue Jun 14, 2022 · 12 comments · Fixed by #14295
Closed

SSH control host port setting not used when tunneling #13758

wesen opened this issue Jun 14, 2022 · 12 comments · Fixed by #14295

Comments

@wesen
Copy link

wesen commented Jun 14, 2022

Environment

  • OS Version / Instance: cloud.airbyte.io
  • Deployment: cloud.airbyte.io
  • Source Connector and version: airbyte/source-mysql-strict-encrypt 0.5.10
  • Destination Connector and version: airbyte/destination-postgres-strict-encrypt 0.1.6
  • Step where error happened: Sync job

Current Behavior

The sync script does not use the tunnel_port setting. This happens in sshtunneling.sh I believe. We have ssh running on port 2222 but the script connects to port 22.

Expected Behavior

The sync script should setup the ssh tunnel to the correct port.

Logs

logs-241062.txt

Steps to Reproduce

  1. Configure a ssh tunnel port for a mysql source/postgresql destination
  2. Sync
  3. Fail

Are you willing to submit a PR?

Yes. Patch attached.
ssh-tunnel-port.patch.txt

@marcosmarxm
Copy link
Member

Thanks for reporting this @wesen, are you going to submit a PR to fix it? The issue happens when you use. a custom port different from 22 right?

@wesen
Copy link
Author

wesen commented Jun 14, 2022

@marcosmarxm I can make a PR. The thing is that I don't really have time to set up airbyte locally for testing, I wanted to use the SaaS version (because I don't have the time). Do you want me to open a PR still?

@marcosmarxm
Copy link
Member

SaaS = Airbyte Cloud? I think it's valid to you open the PR, team can help reviewing and doing the test.

@wesen
Copy link
Author

wesen commented Jun 14, 2022

@marcosmarxm thanks, will do

wesen added a commit to wesen/airbyte that referenced this issue Jun 14, 2022
In Airbyte Cloud, the SSH tunnel port option is not used when using a
port different than 22.

This adds support for the tunnel_port option to the sshtunneling.sh script.

This patch is untested, because I don't have time to setup a local test
environment (this is the reason to use cloud in the first place).

A more detailed bug report can be found at airbytehq#13758.
@marcosmarxm
Copy link
Member

@wesen do you mind sending a message in Intercom to get help from our cloud support team?

@erica-airbyte
Copy link
Contributor

@wesen I have created a cloud ticket for our engineers to dig into when this connector is prioritized! It is currently in the alpha stages so I do not have an ETA but if I have any updates I will reach out!

Also, thank you so much for your investigation! As Marcos mentioned, if you ever have question or need help investigating Airbyte cloud issues please do not hesitate to reach out to the Cloud support team by select "Support" in the bottom left corner of the platform and chatting in or opening a case!

@grishick
Copy link
Contributor

@alexandr-shegeda moving this to JGL team. The tasks here are:

  • reproduce the problem with MySQL source
  • check if the problem is reproducible with Postgres Source
  • check if the problem is reproducible with MS SQL Source
  • fix (might want to start with the patch uploaded by @wesen)

@wesen
Copy link
Author

wesen commented Jun 20, 2022

thanks a lot @erica-airbyte and @grishick! Is there anything else you might need from me right now?

@marcosmarxm marcosmarxm added this to the Zendesk milestone Jun 20, 2022
@erica-airbyte
Copy link
Contributor

@wesen Not at the moment! You can follow along here or I can circle back when there is an update!

@kimerinn
Copy link
Contributor

#14295

@kimerinn kimerinn linked a pull request Jun 30, 2022 that will close this issue
37 tasks
@kimerinn
Copy link
Contributor

With last update from master normalization and fix is working

@wesen
Copy link
Author

wesen commented Jul 28, 2022

What is the best way to try this out? I rebased on master and ran the stack with docker-compose up, which then fetches airbyte/destination-postgres:0.3.21 which ultimately fails with the usual

2022-07-28 15:55:40 normalization > Running: ssh -f -N -M -o StrictHostKeyChecking=no -S {control socket} -i {key file} -l ubuntu -L 50001:XXXX.com:5432 control.thetreecenter.com
2022-07-28 15:56:22 normalization > ssh: connect to XXXX.com port 22: Connection refused
2022-07-28 15:56:40 normalization >            [--event-buffer-size EVENT_BUFFER_SIZE]
2022-07-28 15:56:40 normalization >   --event-buffer-size EVENT_BUFFER_SIZE
2022-07-28 15:56:40 normalization > 
2022-07-28 15:56:40 normalization > DBT >=1.0.0 detected; using 10K event buffer size
2022-07-28 15:56:40 normalization > 

Is there a way to point it to use another image? I tried to muck around with it a bit last week but sadly I don't know enough to figure out where that docker image value is set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants