Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react-select #16023

Closed
krishnaglick opened this issue Aug 26, 2022 · 2 comments · Fixed by #16027
Closed

Upgrade react-select #16023

krishnaglick opened this issue Aug 26, 2022 · 2 comments · Fixed by #16027
Assignees
Labels
area/frontend Related to the Airbyte webapp

Comments

@krishnaglick
Copy link
Contributor

krishnaglick commented Aug 26, 2022

Our react-select library is one major version out of date, and we rely on a @types library which isn't wholly accurate. Notably we have a @ts-expect-error within our usage of it because the types are overly-specific and incorrect.

We should upgrade to the latest react-select (5.4.0 at the time of writing) which does not require an @types library and fix the bugs that occur.

We have certain usages wrapped up in styled components and we should remove the usage of styled-components.

I expect this to be a non-trivial upgrade. Migration guide

@krishnaglick krishnaglick added the area/frontend Related to the Airbyte webapp label Aug 26, 2022
@octavia-squidington-iii
Copy link
Collaborator

cc @airbytehq/frontend

@krishnaglick
Copy link
Contributor Author

Removing styled components from this blew the upgrade well out of scope. See #16439 for that work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants