Upgrade React Select #16027
Merged
Upgrade React Select #16027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
teallarson
reviewed
Sep 1, 2022
|
A few notes:
|
krishnaglick
commented
Sep 1, 2022
| @@ -24,7 +24,8 @@ const Separator = styled.div` | |||
| padding: 0 5px; | |||
| `; | |||
|
|
|||
| const SingleValue: React.FC<IProps> = (props) => { | |||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | |||
| const SingleValue: React.FC<IProps<any>> = (props) => { | |||
There was a problem hiding this comment.
I think the weird component prop-drilling could be refactored out so these could be correctly typed.
There was a problem hiding this comment.
While I agree with splitting this apart if possible, is there any way we can go with unknown for now. The any here currently actually allows us to access props.data.value below, while props.data could actually be undefined (at least according to types) and then throw us an exception at runtime.
|
krishnaglick
requested review from
teallarson
and removed request for
teallarson
teallarson
requested changes
Sep 8, 2022
krishnaglick
force-pushed
the
kc/upgrade-react-select
branch
from
3b8817b
to
e06117c
Compare
Pulled out the styled components removal work as it quickly got overly complex. This is "fixed" |
teallarson
approved these changes
Sep 13, 2022
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
* I'm not in love with the end result here, but it's been upgraded and compiles. * Fixing overflow text issue * Tim CR
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* I'm not in love with the end result here, but it's been upgraded and compiles. * Fixing overflow text issue * Tim CR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #16023
The old react-select setup made a lot of assumptions, abused certain facets of the library, and had some weird typing errors.
This upgrade is intended to put us in a better position for changes and improvements in the future. A number of the assumptions that were made still exist and will likely need a full rewrite in the future to increase maintainability.
For the future of our use of react-select, I feel like we should be able to get away from the whole
components={components}and instead reference things more simply, and with better types. That would be a larger refactor that what's reasonable here however.