Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snowflake destination should set application ID in JDBC param #19250

Closed
grishick opened this issue Nov 9, 2022 · 1 comment · Fixed by #19302
Closed

Snowflake destination should set application ID in JDBC param #19250

grishick opened this issue Nov 9, 2022 · 1 comment · Fixed by #19302
Assignees
@etsybaev
Labels
team/destinations Destinations team's backlog

Comments

@grishick
Copy link
Contributor

grishick commented Nov 9, 2022 •
edited
Loading

as described in https://airbytehq-team.slack.com/archives/C046LMDDY6N/p1666972075127309

Snowflake destination should set the JDBC URL param application to airbyte_cloud or airbyte_oss

Currently, snowflake destination reports application as "airbyte" regardless of environment. This was added in the context of this issue in this pr
@grishick grishick added team/db-dw-sources Backlog for Database and Data Warehouse Sources team team/destinations Destinations team's backlog good first issue and removed team/db-dw-sources Backlog for Database and Data Warehouse Sources team labels Nov 9, 2022
@grishick
Copy link
Contributor Author

Grooming notes: it may be better to use AdaptiveDestinationRunner for this.

@etsybaev etsybaev self-assigned this Nov 10, 2022
@etsybaev etsybaev linked a pull request Nov 11, 2022 that will close this issue
Destination Snowflake: set jdbc application env variable depends on env - airbyte_oss or airbyte_cloud #19302
Merged
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etsybaev etsybaev

Labels
team/destinations Destinations team's backlog
Projects
None yet
Milestone
No milestone
3 participants
@natikgadzhi @grishick @etsybaev