-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google rejects applications for developer tokens #1981
Comments
@sherifnada I think we should give an example of message to write in the documentation to have a successful application. |
Here's what I wrote in response to their rejection. Fingers crossed!
|
Thanks for the sample @zestyping -- we'll update our docs. |
Don't act too soon—they rejected my appeal just now. 😢
|
For this process to work reliably for users, we'll need to get whitelisted by Google. @johnlafleur is reaching out to some connections to understand how to go through the process. |
Unfortunately, it seems they got through the process for Gmail, but not for Google Ads. |
Action Items:
|
update: I've submitted a support request with Google to address this problem. |
Submitted another request to the Google Adwords API compliance team per the instructions given to me by support |
Response from Google:
It sounds like the main issue is that they want to be able to resolve any issues to Airbyte directly. For example, if our connector hammers the API with rate limiting but company XYZ is the one running that connector, they want to be able to reach out to us directly asking us to fix the problem, not to XYZ. Will follow up with them seeing what a middle ground here can be. |
My email to Google:
Their response:
|
Can you confirm that they accept Singer?
…On Sat, Mar 6, 2021 at 7:16 AM Sherif A. Nada ***@***.***> wrote:
My email to Google:
Hi Ryan,
Thank you for your prompt response.
Airbyte is MIT-licensed, which means a user of Airbyte owns the copy of
Airbyte they are using and can modify it however they need. While Airbyte
builds its connectors in compliance with rate limiting, best practices
etc.. a user could edit that version of Airbyte (for example to add a
feature that they need) and in doing so violate best practices around rate
limiting. In this case, Google will actually want to reach out to the user,
not to Airbyte, because they are the ones that ultimately control the
behavior of the software. Using Airbyte is like using code that was
downloaded from the internet: the minute a user downloads it, Airbyte can
no longer control it, and the user can (and is expected to) edit it to fit
their needs.
It's also important to note that the usage pattern described in your email
(users of Airbyte use Airbyte's API token) is also in violation of the
"Allowing automated use of your API token" section of the policy: because
the software is open source, we would have to physically share our
developer token with every user of Airbyte. This would make it impossible
for us to control access to the token, and it would be very easy for it to
leak. This would make it trivial to impersonate Airbyte as an API client,
and ultimately defeats Google's goal of tracking down issues to the entity
that caused them like you mention (" issues have to be resolved by
AirByte").
In light of this information, would you please reconsider the original
request to whitelist Airbyte when a user requests a developer token?
Their response:
After further discussion of your situation with our product teams, we are
unable to grant your request for a developer token to be used with a
third-party tool you do not own or manage.
A developer token is a means to enable your application to connect to the
Google Ads API. This token must belong to and be managed by the developer
responsible for building and maintaining the codebase of the app. You
should not share your dev token with another entity whose codebase you
don’t manage. Additionally you should not build your app in a manner that
requires clients to obtain a developer token for it to be used.
Unfortunately we are unable to modify this policy and must apply it
consistently across our developers.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1981 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQLCVQUCQXXTTS73H76JBS3TCE3ZZANCNFSM4XFJUT7Q>
.
|
My response:
Their response:
|
The saga continues. Google said Singer is OK so i'm trying to understand how Airbyte is different |
I think we will get some definitive answer soon. In the meantime, I got an possible explanation:
|
stopgap docs: #2628 |
Just got the confirmation that Google whitelisted Airbyte!
I will update the documentation accordingly tomorrow |
Fabulous! Congratulations!
—Ping
…On Thu, Apr 15, 2021, 19:15 Michel Tricot ***@***.***> wrote:
Just got the confirmation that Google whitelisted Airbyte!
Moving forward, the product team have decided to allow exceptions if
developer applying for a dev token can confirm that they are able to modify
the codebase interacting with the API and have access to the server running
the code.
I will update the documentation accordingly tomorrow
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1981 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABZUNQLLU6WXFZDLHCTUO3TI6MSZANCNFSM4XFJUT7Q>
.
|
I'm currently trying to get this set up as well and running into similar issues. |
@Rachel-Norris I'm at the exactly the same step, have you solved with the design document |
@sherifnada @andyjih @Amruta-Ranade any guidance here on design document? |
Do we have any previously accepted design docs or is this a new requirement? If it's the latter, can we find out what exactly Google's asking for? |
Sounds like it's a new requirement @Rachel-Norris - are you able to share what's being requested to be included in the design doc? |
If I recall they have always asked for a design document. I'm not sure if we have one that we've provided as guidance for community members in the past though or not. |
They are requesting a design document. Please can we have one provided to us? |
Hey @misteryeo and @LauraC91, I asked for more information about the design doc and they just sent me this example. However in the end, I decided to use the cloud version as I was running into similar issues with other APIs access requests as well and it was taking up a lot of time. Hopefully this helps and let me know if you get anywhere |
Any updates about the design docs? |
was able to use the above example by @Rachel-Norris successfully for Basic Access, giving just the most basic info about Airbyte & our use-case GoogleAds team came back to me with a couple of questions over several mails, so make sure to answer those directly if you can:
|
@vincent-el Thank you very much for the reply. This was basically what I fill except for the third item. Thanks for the advice. |
Has anyone gone through this process recently? I've been waiting over two months for approval. I got an email about 2 weeks ago with similar questions to Vincent, but nothing since. |
This is not a software bug, but a different kind of problem.
Expected Behavior
I followed the procedure described in the documentation for setting up a Google AdWords integration, hoping to get a developer token to use with Airbyte.
Current Behavior
Unfortunately, Google rejected my application with the following message:
Severity of the bug for you
Critical. If we can't use Airbyte with Google AdWords, we can't use Airbyte. :(
The text was updated successfully, but these errors were encountered: