Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate version bump and package publishing for airbyte-cdk #19981

Closed
clnoll opened this issue Dec 1, 2022 · 1 comment
Closed

Automate version bump and package publishing for airbyte-cdk #19981

clnoll opened this issue Dec 1, 2022 · 1 comment
Assignees
Labels
CDK Connector Development Kit from/connector-ops team/extensibility technical-debt issues to fix code smell type/enhancement New feature or request

Comments

@clnoll
Copy link
Contributor

clnoll commented Dec 1, 2022

Tell us about the problem you're trying to solve

There are two issues when publishing the CDK:

  1. Many people could be working on the CDK in parallel, which results in version conflicts between in-flight PRs for the airbyte-cdk package
  2. Publishing the CDK is done from a branch, which can lead to nasty race conditions, not to mention being tedious/manual

Describe the solution you’d like

We could solve the two problems at once, or we could solve just one or the other.
To solve 1 we need to add a GitHub Action to bump the version and publish the package on merge to master. If we do this, we'll want a way to indicate whether it's a major/minor version change. One possible solution could be to use the commit message, or possibly the PR description since the template indicates whether there are breaking changes.

To solve 2 we need a Github action that checks whether the airbyte-cdk directory was changed on merge to master, and runs the publish workflow if so. We will also need a clear path for error recovery if the publishing fails for any reason.

The implementer of this issue is free to think about whether to solve both issues vs. just one, and the sequencing of a solution.

Describe the alternative you’ve considered or used

We could queue up the PRs that would require a version bump and merge them once a day. We might end up wanting to do this eventually anyway, with or without automatically bumping the version, so it's somewhat orthogonal.

maxi297 added a commit that referenced this issue Jan 9, 2023
maxi297 added a commit that referenced this issue Jan 10, 2023
maxi297 added a commit that referenced this issue Jan 11, 2023
* [ISSUE #19981] testing version bump

* [ISSUE #19981] debugging part-to-bump

* [ISSUE #19981] further debugging on part-to-bump

* [ISSUE #19981] further debugging on part-to-bump yet again

* [ISSUE #19981] further debugging on part-to-bump yet again and again

* [ISSUE #19981] improving on first successful attempt

* [ISSUE #19981] adding changelog and concurrency

* [ISSUE #19981] update version in .bumpversion.cfg

* [ISSUE #19981] testing Slack notification with working channel

* [ISSUE #19981] documentation and clean up before PR

* [ISSUE #19981] make changelog-message optional

* [ISSUE #19981] align version with new release

* [ISSUE #19981] code review
jbfbell pushed a commit that referenced this issue Jan 13, 2023
* [ISSUE #19981] testing version bump

* [ISSUE #19981] debugging part-to-bump

* [ISSUE #19981] further debugging on part-to-bump

* [ISSUE #19981] further debugging on part-to-bump yet again

* [ISSUE #19981] further debugging on part-to-bump yet again and again

* [ISSUE #19981] improving on first successful attempt

* [ISSUE #19981] adding changelog and concurrency

* [ISSUE #19981] update version in .bumpversion.cfg

* [ISSUE #19981] testing Slack notification with working channel

* [ISSUE #19981] documentation and clean up before PR

* [ISSUE #19981] make changelog-message optional

* [ISSUE #19981] align version with new release

* [ISSUE #19981] code review
erohmensing added a commit that referenced this issue Jan 14, 2023
Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>
maxi297 added a commit that referenced this issue Jan 17, 2023
* [ISSUE #19981] adding slack notification to airbyte cdk release

* [ISSUE #19981] change default release-type and change slack channel

* [ISSUE #19981] code review - precising error messages

* commit for CI

* commit for CI

* commit for CI
maxi297 added a commit that referenced this issue Jan 18, 2023
@maxi297 maxi297 closed this as completed Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit from/connector-ops team/extensibility technical-debt issues to fix code smell type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants