-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate version bump and package publishing for airbyte-cdk
#19981
Labels
CDK
Connector Development Kit
from/connector-ops
team/extensibility
technical-debt
issues to fix code smell
type/enhancement
New feature or request
Comments
maxi297
added a commit
that referenced
this issue
Jan 6, 2023
maxi297
added a commit
that referenced
this issue
Jan 6, 2023
maxi297
added a commit
that referenced
this issue
Jan 6, 2023
maxi297
added a commit
that referenced
this issue
Jan 6, 2023
maxi297
added a commit
that referenced
this issue
Jan 6, 2023
maxi297
added a commit
that referenced
this issue
Jan 6, 2023
maxi297
added a commit
that referenced
this issue
Jan 9, 2023
maxi297
added a commit
that referenced
this issue
Jan 9, 2023
maxi297
added a commit
that referenced
this issue
Jan 9, 2023
maxi297
added a commit
that referenced
this issue
Jan 9, 2023
maxi297
added a commit
that referenced
this issue
Jan 11, 2023
* [ISSUE #19981] testing version bump * [ISSUE #19981] debugging part-to-bump * [ISSUE #19981] further debugging on part-to-bump * [ISSUE #19981] further debugging on part-to-bump yet again * [ISSUE #19981] further debugging on part-to-bump yet again and again * [ISSUE #19981] improving on first successful attempt * [ISSUE #19981] adding changelog and concurrency * [ISSUE #19981] update version in .bumpversion.cfg * [ISSUE #19981] testing Slack notification with working channel * [ISSUE #19981] documentation and clean up before PR * [ISSUE #19981] make changelog-message optional * [ISSUE #19981] align version with new release * [ISSUE #19981] code review
maxi297
added a commit
that referenced
this issue
Jan 11, 2023
maxi297
added a commit
that referenced
this issue
Jan 12, 2023
maxi297
added a commit
that referenced
this issue
Jan 13, 2023
jbfbell
pushed a commit
that referenced
this issue
Jan 13, 2023
* [ISSUE #19981] testing version bump * [ISSUE #19981] debugging part-to-bump * [ISSUE #19981] further debugging on part-to-bump * [ISSUE #19981] further debugging on part-to-bump yet again * [ISSUE #19981] further debugging on part-to-bump yet again and again * [ISSUE #19981] improving on first successful attempt * [ISSUE #19981] adding changelog and concurrency * [ISSUE #19981] update version in .bumpversion.cfg * [ISSUE #19981] testing Slack notification with working channel * [ISSUE #19981] documentation and clean up before PR * [ISSUE #19981] make changelog-message optional * [ISSUE #19981] align version with new release * [ISSUE #19981] code review
erohmensing
added a commit
that referenced
this issue
Jan 14, 2023
maxi297
added a commit
that referenced
this issue
Jan 16, 2023
maxi297
added a commit
that referenced
this issue
Jan 18, 2023
maxi297
added a commit
that referenced
this issue
Jan 18, 2023
maxi297
added a commit
that referenced
this issue
Jan 18, 2023
maxi297
added a commit
that referenced
this issue
Jan 18, 2023
maxi297
added a commit
that referenced
this issue
Jan 24, 2023
maxi297
added a commit
that referenced
this issue
Jan 24, 2023
maxi297
added a commit
that referenced
this issue
Jan 25, 2023
maxi297
added a commit
that referenced
this issue
Jan 25, 2023
This was referenced Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CDK
Connector Development Kit
from/connector-ops
team/extensibility
technical-debt
issues to fix code smell
type/enhancement
New feature or request
Tell us about the problem you're trying to solve
There are two issues when publishing the CDK:
airbyte-cdk
packageDescribe the solution you’d like
We could solve the two problems at once, or we could solve just one or the other.
To solve 1 we need to add a GitHub Action to bump the version and publish the package on merge to
master
. If we do this, we'll want a way to indicate whether it's a major/minor version change. One possible solution could be to use the commit message, or possibly the PR description since the template indicates whether there are breaking changes.To solve 2 we need a Github action that checks whether the
airbyte-cdk
directory was changed on merge to master, and runs the publish workflow if so. We will also need a clear path for error recovery if the publishing fails for any reason.The implementer of this issue is free to think about whether to solve both issues vs. just one, and the sequencing of a solution.
Describe the alternative you’ve considered or used
We could queue up the PRs that would require a version bump and merge them once a day. We might end up wanting to do this eventually anyway, with or without automatically bumping the version, so it's somewhat orthogonal.
The text was updated successfully, but these errors were encountered: