Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix all ❌ and ⚠️ in ci_check_dependency (full TODO list) #20324

Closed
erohmensing opened this issue Dec 9, 2022 · 0 comments · Fixed by #20666
Closed

fix all ❌ and ⚠️ in ci_check_dependency (full TODO list) #20324

erohmensing opened this issue Dec 9, 2022 · 0 comments · Fixed by #20666

Comments

@erohmensing
Copy link
Contributor

erohmensing commented Dec 9, 2022

Fix the last of existing issues that ci_check_dependency catches, so that devs can trust that if there are issues on their PRs, they need to address them before merging.

Example PRs that have fixed other issues:

A list of all the issues with the affected connectors can be found on this draft PR, where I edited the ci_check_dependency script to report on all existing connectors. Please pull the latest master and merge it into the branch before working on it, maybe even again once your changes are approved so we don't miss anything. If you work on that branch, make sure to remove the edits to the ci_check_dependency script (or just revert the first commit) before merging. We should then update the connector org about renewed expectations toward paying attention to this CI check.

Notes from @evantahler:

  • we can ignore the source-scaffold-* and destination-scaffold-* connectors
  • we can (probably?) ignore source-relational-* connector too
  • we can ignore source-python-http-tutorial

We can do the above by extending the current behavior around IGNORED_DESTINATIONS.

@erohmensing erohmensing changed the title fix _all_ ❌ and ⚠️ in ci_check_dependency (full TODO list) fix all ❌ and ⚠️ in ci_check_dependency (full TODO list) Dec 9, 2022
@evantahler evantahler self-assigned this Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants