You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix the last of existing issues that ci_check_dependency catches, so that devs can trust that if there are issues on their PRs, they need to address them before merging.
A list of all the issues with the affected connectors can be found on this draft PR, where I edited the ci_check_dependency script to report on all existing connectors. Please pull the latest master and merge it into the branch before working on it, maybe even again once your changes are approved so we don't miss anything. If you work on that branch, make sure to remove the edits to the ci_check_dependency script (or just revert the first commit) before merging. We should then update the connector org about renewed expectations toward paying attention to this CI check.
erohmensing
changed the title
fix _all_ ❌ and ⚠️ in ci_check_dependency (full TODO list)
fix all ❌ and ⚠️ in ci_check_dependency (full TODO list)
Dec 9, 2022
Fix the last of existing issues that
ci_check_dependency
catches, so that devs can trust that if there are issues on their PRs, they need to address them before merging.Example PRs that have fixed other issues:
ci_check_dependency
#20274A list of all the issues with the affected connectors can be found on this draft PR, where I edited the
ci_check_dependency
script to report on all existing connectors. Please pull the latest master and merge it into the branch before working on it, maybe even again once your changes are approved so we don't miss anything. If you work on that branch, make sure to remove the edits to theci_check_dependency
script (or just revert the first commit) before merging. We should then update the connector org about renewed expectations toward paying attention to this CI check.Notes from @evantahler:
We can do the above by extending the current behavior around
IGNORED_DESTINATIONS
.The text was updated successfully, but these errors were encountered: