Destination doc and warning updates #20110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iv
added
the
area/documentation
octavia-squidington-iv
added
connectors/source/faker
area/connectors
37 tasks
alafanechere
approved these changes
Dec 6, 2022
alafanechere
requested changes
Dec 6, 2022
Co-authored-by: Augustin <augustin@airbyte.io>
|
Thanks for the typo-catches @alafanechere! |
alafanechere
approved these changes
Dec 6, 2022
This was referenced Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20075.
Working though the list of connector issues here #19993 (comment) solving missing chagelogs and missing docs pages entirely.
After this update, a missing strict-encrypt connector or
destination-jdbcwon't trigger a failure. We now use 🔵 for skipped connectors in this check.To test the python code, add a file like this the root of your airbyte project
changed_files.txt:and then run
python3 ./tools/bin/ci_check_dependency.py ./changed_files.txtto see the generated comment markdown atcomment_body.md