-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove NormalizationRunnerFactory #19993
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DBT and normalizationImage fields. Added to the GenerateInputActivityImpl and TemporalClient classes code parts for read destination_definition.yaml and get suportDBT and normalizationImage fields. Added logging and comparing normalization images from NormalizationRunnerFactory and destination_definition.yaml
…korotkov/remove_factory � Conflicts: � airbyte-commons-worker/src/main/java/io/airbyte/workers/normalization/NormalizationRunnerFactory.java
…korotkov/remove_factory
…remove_factory � Conflicts: � airbyte-commons-worker/src/main/java/io/airbyte/workers/normalization/NormalizationRunnerFactory.java � airbyte-commons-worker/src/test/java/io/airbyte/workers/normalization/NormalizationRunnerFactoryTest.java � airbyte-container-orchestrator/src/main/java/io/airbyte/container_orchestrator/DbtJobOrchestrator.java � airbyte-container-orchestrator/src/main/java/io/airbyte/container_orchestrator/NormalizationJobOrchestrator.java � airbyte-integrations/bases/standard-destination-test/src/main/java/io/airbyte/integrations/standardtest/destination/DestinationAcceptanceTest.java � airbyte-workers/src/main/java/io/airbyte/workers/temporal/sync/DbtTransformationActivityImpl.java � airbyte-workers/src/main/java/io/airbyte/workers/temporal/sync/NormalizationActivityImpl.java
octavia-squidington-iv
added
area/connectors
Connector related issues
area/platform
issues related to the platform
area/server
area/worker
Related to worker
connectors/destination/mysql
labels
Dec 1, 2022
octavia-squidington-iv
added
area/frontend
Related to the Airbyte webapp
connectors/destination/clickhouse
connectors/destination/clickhouse-strict-encrypt
connectors/source/bing-ads
connectors/source/facebook-marketing
connectors/source/amplitude
connectors/source/bigquery
connectors/source/close-com
connectors/source/kafka
connectors/source/mailchimp
connectors/source/mysql
connectors/source/postgres
connectors/source/snowflake
connectors/source/jdbc
connectors/source/scaffold-java-jdbc
connectors/source/relational-db
connectors/source/firebolt
connectors/source/mysql-strict-encrypt
connectors/source/postgres-strict-encrypt
connectors/source/faker
connectors/source/rki-covid
connectors/source/elasticsearch
connectors/source/rd-station-marketing
connectors/source/gridly
labels
Dec 8, 2022
andriikorotkov
temporarily deployed
to
more-secrets
December 8, 2022 17:22 — with
GitHub Actions
Inactive
andriikorotkov
temporarily deployed
to
more-secrets
December 8, 2022 17:22 — with
GitHub Actions
Inactive
andriikorotkov
temporarily deployed
to
more-secrets
December 8, 2022 20:31 — with
GitHub Actions
Inactive
andriikorotkov
temporarily deployed
to
more-secrets
December 8, 2022 20:31 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/api
Related to the api
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
area/frontend
Related to the Airbyte webapp
area/platform
issues related to the platform
area/server
area/worker
Related to worker
CDK
Connector Development Kit
connectors/destination/clickhouse
connectors/destination/clickhouse-strict-encrypt
connectors/destination/mysql
connectors/destination/snowflake
connectors/source/amplitude
connectors/source/bigquery
connectors/source/bing-ads
connectors/source/close-com
connectors/source/elasticsearch
connectors/source/facebook-marketing
connectors/source/faker
connectors/source/firebolt
connectors/source/gridly
connectors/source/jdbc
connectors/source/kafka
connectors/source/mailchimp
connectors/source/mysql
connectors/source/mysql-strict-encrypt
connectors/source/postgres
connectors/source/postgres-strict-encrypt
connectors/source/rd-station-marketing
connectors/source/relational-db
connectors/source/rki-covid
connectors/source/scaffold-java-jdbc
connectors/source/snowflake
kubernetes
normalization
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Removed NormalizationRunnerFactory.class and updated all places where it using. Updated DefaultNormalizationRunner.class and changed
NormalizationRunnerFactory#create
tonew DefaultNormalizationRunner
. Updated DestinationAcceptanceTest and added methods for read inaormation about normalization and DBT from definition file. Updated check_images_exist.sh to get information fromdestination_definition.yaml
file instead of NormalizationRunnerFactory classHow
Describe the solution
Recommended reading order
DefaultNormalizationRunner.java
DestinationAcceptanceTest.java
check_images_exist.sh
🚨 User Impact 🚨
Removed NormalizationRunnerFactory.class. Thereby we separate the normalization from the platform.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changesTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.