Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement v2 test suites #2181

Closed
sherifnada opened this issue Feb 23, 2021 · 1 comment · Fixed by #2792
Closed

Implement v2 test suites #2181

sherifnada opened this issue Feb 23, 2021 · 1 comment · Fixed by #2792
Assignees
@keu
Labels
area/live-tests type/enhancement New feature or request
Milestone
Connectors April ...

Comments

@sherifnada
Copy link
Contributor

Tell us about the problem you're trying to solve

As described in the tech spec
@sherifnada sherifnada added this to the 2021-02-26 milestone Feb 23, 2021
@sherifnada sherifnada assigned sherifnada and unassigned sherifnada Feb 23, 2021
@cgardens cgardens modified the milestones: 2021-02-26, 2021-03-05 Mar 1, 2021
@sherifnada sherifnada self-assigned this Mar 8, 2021
@sherifnada sherifnada assigned keu and unassigned sherifnada and keu Mar 15, 2021
@keu keu self-assigned this Mar 20, 2021
@keu
Copy link
Contributor

keu commented Mar 23, 2021 •
edited
Loading

Scoping:

  • Implement core tests (2h)
  • Implement full refresh tests (2h)
  • Implement incremental tests (3h)

Total dev estimate: 7h

@keu keu mentioned this issue Mar 24, 2021
Closed
@keu keu mentioned this issue Apr 7, 2021
Merged
2 tasks
@keu keu linked a pull request Apr 8, 2021 that will close this issue
Standard Tests: Implement v2 test suites #2181 #2792
Merged
2 tasks
keu added a commit that referenced this issue Apr 19, 2021
@keu @eugene-kulak
Standard Tests: Implement v2 test suites #2181 (#2792)
0247670 
* fixes and address comments from @sherifnada

* fix tests

* fix leaking of secrets in the output

* fix package path

* fix imports

* hide secrets

* fix logs

* fix sequential read test

* fix build

* format

Co-authored-by: Eugene Kulak <kulak.eugene@gmail.com>
@keu keu closed this as completed Apr 19, 2021
keu added a commit that referenced this issue Apr 20, 2021
@keu
Standard Tests: create modular standard test suite v2 scaffolding (#2702
1755847 
)

* Standard Tests: Implement v2 test suites #2181 (#2792)
* rename standard tests (v2) to source_acceptance_test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keu keu

Labels
area/live-tests type/enhancement New feature or request
Projects
None yet
Milestone
Connectors April 16th, 2021
Development

Successfully merging a pull request may close this issue.

Standard Tests: Implement v2 test suites #2181 airbytehq/airbyte
3 participants
@keu @sherifnada @cgardens