Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running Google Adwords Singer's read command on MacOS is causing an error #3324

Closed
Zirochkaa opened this issue May 10, 2021 · 0 comments
Closed
Assignees
Labels
area/connectors Connector related issues type/bug Something isn't working

Comments

@Zirochkaa
Copy link
Contributor

Zirochkaa commented May 10, 2021

Description

When I started working on #2929 issue I saw another issue with running read command on MacOS.

Expected Behavior

Each date field in STATE records should have the right format, for example 2020-06-02T00:00:00.000000Z.

Current Behavior

Each STATE record has date fields (like last_attribution_window_date or date) which start with 4Y which is the wrong date value, here is an example of such value - "4Y-05-10T00:00:00.000000Z". Data before 2020-06-01 is being handled without any error, but once code starts to handle data for 2020-06-02

  • here we have an error dateutil.parser._parser.ParserError: Unknown string format: 4Y-06-02T00:00:00.000000Z (more details about the error and where it occurs you may find in attached logs file).

Logs

logs.txt

Steps to Reproduce

  1. On MacOS go to the folder with source-google-adwords-singer connector.
  2. In this folder run:
    python -m main_dev read --config <PATH_TO_config.json_FILE> --catalog <PATH_TO_catalog.json_FILE>
    

Severity of the bug for you

Medium

Airbyte Version

0.22.2-alpha

Connector Version (if applicable)

0.2.1

Additional context

I think solution may be found here:
singer has strftime function, which they suppose to call (I guess) in order to format date from '4Y-05-07T13:42:57.130791Z' to '2021-05-07T13:42:57.130791Z'. This function is being called by our code at the beginning of read execution and it works (meaning that this function really formats '4Y-05-07T13:42:57.130791Z' into '2021-05-07T13:42:57.130791Z'). But tap-adwords or singer doesn’t call that strftime function for records, meaning that '4Y-05-07T13:42:57.130791Z' value is being left as it is.

We need to look into tap-adwords and/or singer code and maybe create our own fork.

┆Issue is synchronized with this Asana task by Unito

@Zirochkaa Zirochkaa added type/bug Something isn't working area/connectors Connector related issues zazmic labels May 10, 2021
@Zirochkaa Zirochkaa self-assigned this May 10, 2021
@Zirochkaa Zirochkaa added this to the Connectors May 28th, 2021 milestone May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants