Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Google Adwords CI & publish new version #2929

Closed
sherifnada opened this issue Apr 17, 2021 · 4 comments · Fixed by #4205
Closed

fix Google Adwords CI & publish new version #2929

sherifnada opened this issue Apr 17, 2021 · 4 comments · Fixed by #4205
Assignees
Labels
area/connectors Connector related issues type/bug Something isn't working

Comments

@sherifnada
Copy link
Contributor

sherifnada commented Apr 17, 2021

Description

The Google Adwords CI is failing. I'm pretty sure nothing is wrong with the connector but it seems like we may have no data in the underlying source.

Once this has been fixed, we should bump & publish a new version to pick up the changes from #2918

┆Issue is synchronized with this Asana task by Unito

@sherifnada sherifnada added type/bug Something isn't working area/connectors Connector related issues labels Apr 17, 2021
@sherifnada sherifnada changed the title fix Google Adwords CI fix Google Adwords CI & publish new version Apr 18, 2021
@Zirochkaa Zirochkaa self-assigned this May 3, 2021
@Zirochkaa
Copy link
Contributor

I tried to do a little research and find out when tests started to fail. I went on integration-test workflow page in Actions section but there are 65k+ workflow runs and no search by date :(
Then I found PR #1726 (already merged in master) in which tests are failing.
In above PR in this comment I found mentioning another issue #1805 about adding test data to Google Adwords. This issue is still in backlog and was never done.
Then I found this PR #2688, it was created on April 1 and it's without any issue connected. It also has failing tests.

Right now I can't really tell what caused this problem with tests because it requires more investigation. I believe more information could be found during the task execution.

@sherifnada
Copy link
Contributor Author

Issue is:

Failures (1):
  JUnit Jupiter:ExecutableTestSource:testIncrementalSyncWithState()
    MethodSource [className = 'io.airbyte.integrations.standardtest.source.fs.ExecutableTestSource', methodName = 'testIncrementalSyncWithState', methodParameterTypes = '']
    => org.opentest4j.AssertionFailedError: Expected the first incremental sync to produce records ==> expected: <false> but was: <true>
       org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
       org.junit.jupiter.api.AssertFalse.assertFalse(AssertFalse.java:40)
       org.junit.jupiter.api.Assertions.assertFalse(Assertions.java:218)
       io.airbyte.integrations.standardtest.source.StandardSourceTest.testIncrementalSyncWithState(StandardSourceTest.java:336)
       java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
       java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
       java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
       java.base/java.lang.reflect.Method.invoke(Method.java:564)
       org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:688)
       org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
       [...]

See here: https://github.com/airbytehq/airbyte/runs/2492973569?check_suite_focus=true#step:10:8673

ideas for next steps:

  1. run connector locally and try to reproduce the issue where an incremental sync does not produce any records
  2. understand why checkin catalogs #1 is happening -- an easy way to do this might be to change the config locally until you can get records to appear. If no data is in the source (e.g: if google only allows you to pull report data from <1 year ago) then we'll need to run some ad campaigns potentially. A sandbox would be useful but idk if google has it.

Zirochkaa added a commit that referenced this issue May 5, 2021
Add `tap-adwords==1.13.0` to required packeges in `setup.py` file.
@Zirochkaa Zirochkaa linked a pull request May 5, 2021 that will close this issue
2 tasks
Zirochkaa added a commit that referenced this issue May 5, 2021
Remove `tap-adwords==1.12.0` installation from `Dockerfile` and `build.gradle` files.
Zirochkaa added a commit that referenced this issue May 6, 2021
Zirochkaa added a commit that referenced this issue May 6, 2021
@Zirochkaa Zirochkaa removed their assignment May 8, 2021
@po3na4skld
Copy link
Contributor

The issue is still exist I was faced with it when solving #2903

@keu
Copy link
Contributor

keu commented Jun 14, 2021

  • - move to use SAT tests (30m)
  • - reproduce the issue (4h)
  • - create or update this ticket with a possible fix if an issue discovered (1h)

@keu keu assigned po3na4skld and unassigned keu Jun 16, 2021
@po3na4skld po3na4skld linked a pull request Jun 18, 2021 that will close this issue
12 tasks
@sherifnada sherifnada removed this from the Connectors July 9, 2021 milestone Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues type/bug Something isn't working
Projects
None yet
4 participants