Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDK: Create a generic method for transforming records fields in accordance with streams schemas #5224

Closed
Zirochkaa opened this issue Aug 5, 2021 · 4 comments · Fixed by #6139
Assignees

Comments

@Zirochkaa
Copy link
Contributor

Tell us about the problem you're trying to solve

Right now we have few issues where fields types in records don't match types from streams schemas (#4292, #4841, #4827).

Describe the solution you’d like

It would be nice to have a generic solution, a function or a class (like Transformer class in singer), which will go through each field in records (through nested fields too) and transform types to the ones in streams schemas.

Describe the alternative you’ve considered or used

Right now if we want to change type of fields in records we are using transform() function (like in source-github). In this case we need to manually specify fields and desired types. It works good for root keys, but for nested keys it's not so convenient to use such method.

Additional context

First edition of this task will be implemented in #4827 issue.

Are you willing to submit a PR?

Yes

@Zirochkaa Zirochkaa added type/enhancement New feature or request area/connectors Connector related issues zazmic lang/python CDK Connector Development Kit labels Aug 5, 2021
@Zirochkaa Zirochkaa added this to the Connectors August 20th milestone Aug 5, 2021
@Zirochkaa Zirochkaa self-assigned this Aug 5, 2021
@Zirochkaa
Copy link
Contributor Author

Blocked on #4827.

@Zirochkaa Zirochkaa removed the zazmic label Aug 6, 2021
@keu
Copy link
Contributor

keu commented Aug 10, 2021

@Zirochkaa how is this issue blocked by #4827 ?

@Zirochkaa
Copy link
Contributor Author

@keu we decided to do the first test version of this generic method in Facebook Marketing source in terms of #4827 issue, so this means that I need to add generic function to Facebook Marketing source first, merge it and only then I can move that generic function to CDk (maybe add some improvements).

@keu
Copy link
Contributor

keu commented Aug 11, 2021

ok, lets call it playground

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants