Source Quickbooks: Number data types are being transformed to strings

[maciej-nedza]

Expected Behavior

According to docs supported streams should leave number fields types as numbers in output schema.

Current Behavior

Most of number fields are being transformed to strings.
It's probably caused by these fields in quickbooks-tap being defined as

      "format": "singer.decimal",
      "type": [
        "null",
        "string"
]

Steps to Reproduce

1. Create quickbooks source. Quickbooks lets you create free trial account with demo organisation already holding some test data.
2. Create connection between quickbooks source and any destination.
3. Check the source schema, e. g. Invoices stream and TotalAmt field. It's type is set to string, when it should be a number.

Severity of the bug for you

Medium

Airbyte Version

0.26.2-alpha

Connector Version (if applicable)

0.1.1

[Zirochkaa]

@sherifnada login/password are not in Latspass, only test creds.

[Zirochkaa]

Are the account test credentials available in Lastpass? - yes

Task breakdown

• Go through each stream's schema in sample_files/configured_catalog.json and update fields types according to docs (~7-8h because streams have large schemas, file contains 4.5k+ rows)
• Add acceptance tests (SAT), at least spec, connection, discovery and basic_read tests (basic_read will check types of fields) (~4h)

Note - here is a link to singer code which do request and just yield records, meaning that singer doesn't apply any transformation. So the reason must be in schemas. All schemas were taken from here and for some properties there is the following block:

"format": "singer.decimal",
  "type": [
    "null",
    "string"
  ]

Airbyte doesn't recognize singer.decimal format so we need to remove format field and change type to ["null", "number"] for all properties which actually have number type.
And because of above explanation we need to add SAT first because it will tell us which streams have such error.

Link to task in zira.

[vitaliizazmic]

@Zirochkaa Quickbooks it's Intuit product. We can use its login and password, which is presented in Lastpass.