You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After introducing Flyway migration, any unit test that depends on the database need to run the migrations first. Currently most such unit tests do not do this. It is not a problem now because there is no Flyway migration yet. But we will run into this problem soon.
Expected Behavior
Unit test should work after Flyway migrations are introduced in the future.
Are you willing to submit a PR?
Yes.
The text was updated successfully, but these errors were encountered:
A few days ago we removed the workflow volume from the Kubernetes deployment in order to simplify the set up. This also lets us do away with the workspace PVC.
In theory this isn't needed since the volume is mainly used for logs and our Kube deployment logs out to the Cloud storage.
In the process of doing so, we realised the volume is used to store the temporal workflow id that is later used to cancel the workflow. Thus cancellations stopped working.
This PR:
Adds a migration to add the temporalWorkflowId column to the Attempts table. Exposes various persistent methods for this.
Modify temporal to store the workflow id in this column. Modify cancellation to retrieve the workflow id from the table.
Things to call out:
This approach means the worker now requires access to the jobs DB. I think this is reasonable.
Some tests are disabled since we haven't really stabilised the Flyway + older file-base migrations yet. Follow up ticket has been created (Update config and job persistence unit tests to run migrations #5857) and Liren is working on this.
This issue has been resolved in #7219. Use TestDatabaseProviders to create databases in unit test. It will take care of the initialization and migration.
Current Behavior
After introducing Flyway migration, any unit test that depends on the database need to run the migrations first. Currently most such unit tests do not do this. It is not a problem now because there is no Flyway migration yet. But we will run into this problem soon.
Expected Behavior
Unit test should work after Flyway migrations are introduced in the future.
Are you willing to submit a PR?
Yes.
The text was updated successfully, but these errors were encountered: